Skip to content
This repository was archived by the owner on Dec 24, 2022. It is now read-only.

Revert "Merge pull request #405 from chrisfcarroll/master" #406

Merged
merged 1 commit into from
Apr 16, 2014

Conversation

chrisfcarroll
Copy link
Contributor

Because the commit didn't work and the simplest first step is to revert it.
This reverts commit d9a4e7a, reversing
changes made to 8c32aea.

mythz added a commit that referenced this pull request Apr 16, 2014
Revert "Merge pull request #405 from chrisfcarroll/master"
@mythz mythz merged commit 36fbac6 into ServiceStack:master Apr 16, 2014
@mythz
Copy link
Member

mythz commented Apr 16, 2014

ok cool.

@chrisfcarroll
Copy link
Contributor Author

The difficulty with a proper solution is: CsvSerializer delegates in the end to JsvSerialize.WriteDateTime() which already has some formatting logic driven by JsConfig.DateHandler. So the route I was going we'd end up with the date time format being dependent both on a JsConfig setting and a CsvConfig setting and both settings impacting (I guess) Json serialisation as well as Csv serialisation.

@mythz
Copy link
Member

mythz commented Apr 16, 2014

Well it's better to have one configuration for Date Formatting but you can scope it to only be used in CSV with something like:

using (JsConfig.With(dateHandler:CsvConfig.DateHandler)) {
...
}

@chrisfcarroll
Copy link
Contributor Author

Thx, I'll look into that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants