Skip to content

Fix references to ItemValue, Picture, and PictureType in ApeTag #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

Lepidopteran
Copy link
Contributor

@Lepidopteran Lepidopteran commented Jan 24, 2025

I was looking around in the ApeTag documentation and found the following to be pointing to invalid locations:

  • ItemValue
  • ItemValue::Binary
  • Picture::from_ape_bytes
  • PictureType::Undefined

I updated them to point to the right locations and tested it on my machine.
Feel free to let me know if any changes need to be made. :)

NOTE: This is a duplicate of a previous pull request I made, but with a verified the commit to make GitHub happy.

@Serial-ATA
Copy link
Owner

Thanks! I thought this would've been caught by broken_intra_doc_links, but I guess it doesn't work when the paths are specified like this. 🤔

I imagine more broken links exist, since a bunch of things were moved around in 0.19.0.

This is a duplicate of a previous pull request I made, but with a verified the commit to make GitHub happy

Don't worry about it, commits don't need to be signed.

@Serial-ATA Serial-ATA merged commit 3367067 into Serial-ATA:main Jan 24, 2025
8 checks passed
@Serial-ATA Serial-ATA added this to the 0.22.2 milestone Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants