Skip to content

Make Record default move constructible#95

Open
3XX0 wants to merge 1 commit intoSergiusTheBest:masterfrom
3XX0:master
Open

Make Record default move constructible#95
3XX0 wants to merge 1 commit intoSergiusTheBest:masterfrom
3XX0:master

Conversation

@3XX0
Copy link
Copy Markdown

@3XX0 3XX0 commented May 23, 2018

This allows move-constructing Records in C++11 and above

@SergiusTheBest
Copy link
Copy Markdown
Owner

Hi!

I think Record is never copied or moved. Where do we need that?

@3XX0
Copy link
Copy Markdown
Author

3XX0 commented May 23, 2018

This isn't used in plog itself but this is useful for the application developer.
For example if one wants to save Records in standard containers (say a std::vector<Record>) to defer logging.

@SergiusTheBest
Copy link
Copy Markdown
Owner

Yes, it makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants