-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[rust] Test Selenium Manager on Linux arm64 #16045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dennisameling
wants to merge
7
commits into
SeleniumHQ:trunk
Choose a base branch
from
dennisameling:add-selenium-manager-linux-arm64
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
de5e3b2
[rust] Enable tests in GitHub Actions on Linux arm64
dennisameling a88d4e1
[rust] Selenium Manager: Update tests to work with Linux arm64
dennisameling 94b2d35
Apply AI review suggestions
dennisameling 1855709
Fix formatting
dennisameling 65e8c65
Add release logic for Linux arm64 binaries
dennisameling 38654e3
Merge branch 'trunk' into add-selenium-manager-linux-arm64
cgoldberg 34cbe19
Merge branch 'trunk' into add-selenium-manager-linux-arm64
cgoldberg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,6 +35,7 @@ jobs: | |
include: | ||
- os: macos | ||
- os: ubuntu | ||
- os: ubuntu-24.04-arm | ||
- os: windows | ||
with: | ||
name: Tests (${{ matrix.os }}) | ||
|
@@ -119,17 +120,28 @@ jobs: | |
- name: "Install cross" | ||
run: | | ||
cargo install cross --git https://github.com/cross-rs/cross | ||
- name: "Build release binary" | ||
- name: "Build release binary (x64)" | ||
run: cross build --target x86_64-unknown-linux-musl --release | ||
working-directory: rust | ||
- name: "Build release binary (arm64)" | ||
run: cross build --target aarch64-unknown-linux-musl --release | ||
working-directory: rust | ||
- name: "Rename binary" | ||
run: mv rust/target/x86_64-unknown-linux-musl/release/selenium-manager selenium-manager-linux | ||
run: | | ||
mv rust/target/x86_64-unknown-linux-musl/release/selenium-manager selenium-manager-linux | ||
mv rust/target/aarch64-unknown-linux-musl/release/selenium-manager selenium-manager-linux-arm64 | ||
- name: "Upload release binary" | ||
uses: actions/upload-artifact@v4 | ||
with: | ||
name: selenium-manager-linux | ||
path: selenium-manager-linux | ||
retention-days: 6 | ||
- name: "Upload release binary" | ||
uses: actions/upload-artifact@v4 | ||
with: | ||
name: selenium-manager-linux-arm64 | ||
path: selenium-manager-linux-arm64 | ||
retention-days: 6 | ||
|
||
linux-debug: | ||
name: "Linux Debug" | ||
|
@@ -148,18 +160,30 @@ jobs: | |
- name: "Install cross" | ||
run: | | ||
cargo install cross --git https://github.com/cross-rs/cross | ||
- name: "Build release binary" | ||
- name: "Build release binary (x64)" | ||
run: | | ||
cross build --target x86_64-unknown-linux-musl --profile dev | ||
cd target/x86_64-unknown-linux-musl/debug | ||
tar -cvf ../../../../selenium-manager-linux-debug.tar selenium-manager | ||
working-directory: rust | ||
- name: "Build release binary (arm64)" | ||
run: | | ||
cross build --target aarch64-unknown-linux-musl --profile dev | ||
cd target/aarch64-unknown-linux-musl/debug | ||
tar -cvf ../../../../selenium-manager-linux-arm64-debug.tar selenium-manager | ||
working-directory: rust | ||
- name: "Upload release binary" | ||
uses: actions/upload-artifact@v4 | ||
with: | ||
name: selenium-manager-linux-debug | ||
path: selenium-manager-linux-debug.tar | ||
retention-days: 6 | ||
- name: "Upload release binary" | ||
uses: actions/upload-artifact@v4 | ||
with: | ||
name: selenium-manager-linux-arm64-debug | ||
path: selenium-manager-linux-arm64-debug.tar | ||
retention-days: 6 | ||
|
||
macos-stable: | ||
name: "MacOS Stable" | ||
|
@@ -245,9 +269,10 @@ jobs: | |
- name: "Prepare and Commit" | ||
run: | | ||
linux_sha=$(shasum -a 256 artifacts/selenium-manager-linux/selenium-manager-linux | awk '{print $1}') | ||
linux_arm64_sha=$(shasum -a 256 artifacts/selenium-manager-linux-arm64/selenium-manager-linux-arm64 | awk '{print $1}') | ||
macos_sha=$(shasum -a 256 artifacts/selenium-manager-macos/selenium-manager-macos | awk '{print $1}') | ||
windows_sha=$(shasum -a 256 artifacts/selenium-manager-windows/selenium-manager-windows.exe | awk '{print $1}') | ||
echo "{\"macos\": \"$macos_sha\", \"windows\": \"$windows_sha\", \"linux\": \"$linux_sha\"}" > latest.json | ||
echo "{\"macos\": \"$macos_sha\", \"windows\": \"$windows_sha\", \"linux\": \"$linux_sha\", \"linux-arm64\": \"$linux_arm64_sha\" }" > latest.json | ||
git config --local user.email "[email protected]" | ||
git config --local user.name "Selenium CI Bot" | ||
git add latest.json | ||
|
@@ -266,6 +291,7 @@ jobs: | |
prerelease: false | ||
files: | | ||
artifacts/selenium-manager-linux/selenium-manager-linux | ||
artifacts/selenium-manager-linux-arm64/selenium-manager-linux-arm64 | ||
artifacts/selenium-manager-macos/selenium-manager-macos | ||
artifacts/selenium-manager-windows/selenium-manager-windows.exe | ||
artifacts/selenium-manager-linux-debug/selenium-manager-linux-debug.tar | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Realizing I forgot to add
artifacts/selenium-manager-linux-arm64-debug/selenium-manager-linux-arm64-debug.tar
to this list, so let's keep that in mind as we continue working on this PR.