Skip to content

[build] allow manually rerunning RBE with cache disabled #15680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025

Conversation

titusfortner
Copy link
Member

@titusfortner titusfortner commented Apr 29, 2025

🔗 Related Issues

n/a

💥 What does this PR do?

allows manually executing remote build from GitHub to force rerunning all tests

🔧 Implementation Notes

No change to PR or trunk push, just an added checkbox if kicking off manually

💡 Additional Considerations

This shouldn't be necessary? But sometimes things fail in PRs and I wonder if the cache in trunk is hiding something?

If this doesn't add value, we shouldn't merge it.
@p0deje / @shs96c is there value to this?

🔄 Types of changes

  • New feature (non-breaking change which adds functionality and tests!)

@selenium-ci selenium-ci added the B-build Includes scripting, bazel and CI integrations label Apr 29, 2025
Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ❌

5678 - Not compliant

Non-compliant requirements:

• Fix "Error: ConnectFailure (Connection refused)" when instantiating ChromeDriver multiple times

Requires further human verification:

• The PR is not directly addressing this ticket - it's adding a CI workflow enhancement rather than fixing the ChromeDriver connection issue

1234 - Not compliant

Non-compliant requirements:

• Fix issue where Selenium 2.48 doesn't trigger JavaScript in link's href on click()

Requires further human verification:

• The PR is not directly addressing this ticket - it's adding a CI workflow enhancement rather than fixing the Firefox JavaScript issue

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Parameter Passing

The workflow_dispatch input parameter is being passed to the script, but it's not clear if the parameter will be empty or undefined when the workflow is triggered by pull_request or push events rather than manual dispatch.

run: ./scripts/github-actions/ci-build.sh ${{ github.event.inputs.disable_test_cache }}

Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@titusfortner titusfortner requested review from shs96c and p0deje April 29, 2025 21:43
@titusfortner titusfortner merged commit 70e415a into trunk May 2, 2025
12 checks passed
@titusfortner titusfortner deleted the disable_cache branch May 2, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-build Includes scripting, bazel and CI integrations Review effort 2/5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants