Skip to content

[java][bidi]: enable tests for storage module for edge #15667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 5, 2025
Merged

[java][bidi]: enable tests for storage module for edge #15667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e589c65
enable tests for bidi storage (edge) and permissions
navin772 Apr 25, 2025
1a3f02b
skip `canGetAllCookies()` test in edge
navin772 Apr 25, 2025
599dc8b
Merge branch 'trunk' into java-bidi-enable-tests
navin772 Apr 28, 2025
3e835bc
remove chrome and edge for permissions test
navin772 Apr 28, 2025
f075026
Merge branch 'trunk' into java-bidi-enable-tests
navin772 May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions java/test/org/openqa/selenium/bidi/storage/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ java_selenium_test_suite(
browsers = [
"chrome",
"firefox",
"edge",
],
tags = [
"selenium-remote",
Expand Down
6 changes: 0 additions & 6 deletions java/test/org/openqa/selenium/bidi/storage/StorageCommandsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ public void setUp() {
}

@Test
@NotYetImplemented(EDGE)
public void canGetCookieByName() {
String key = generateUniqueKey();
String value = "set";
Expand Down Expand Up @@ -124,7 +123,6 @@ public void canGetCookieInDefaultUserContext() {
}

@Test
@NotYetImplemented(EDGE)
public void canGetCookieInAUserContext() {
Browser browser = new Browser(driver);
String userContext = browser.createUserContext();
Expand Down Expand Up @@ -177,7 +175,6 @@ key, new BytesValue(BytesValue.Type.STRING, value), appServer.getHostName()),
}

@Test
@NotYetImplemented(EDGE)
public void canAddCookie() {
String key = generateUniqueKey();
String value = "foo";
Expand Down Expand Up @@ -289,7 +286,6 @@ public void canGetAllCookies() {
}

@Test
@NotYetImplemented(EDGE)
public void canDeleteAllCookies() {
addCookieOnServerSide(new Cookie("foo", "set"));
assertSomeCookiesArePresent();
Expand All @@ -303,7 +299,6 @@ public void canDeleteAllCookies() {
}

@Test
@NotYetImplemented(EDGE)
public void canDeleteCookieWithName() {
String key1 = generateUniqueKey();
String key2 = generateUniqueKey();
Expand All @@ -325,7 +320,6 @@ public void canDeleteCookieWithName() {
}

@Test
@NotYetImplemented(EDGE)
public void testAddCookiesWithDifferentPathsThatAreRelatedToOurs() {
driver.get(appServer.whereIs("/common/animals"));

Expand Down