-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[py] Fix test for w3c touch pointer properties #15580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py] Fix test for w3c touch pointer properties #15580
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
It was not moved outside the I love arguing with this AI PR reviewer :) |
|
All tests pass in CI except the 1 failure caused by #15581 (unrelated to this PR) |
User description
💥 What does this PR do?
This PR fixes the
test_touch_pointer_propertiestest in the internal Python test suite. It was failing in CI runs.This test would run fine in isolation, but fail when the entire test file was run because the pointer state was leaked from a previous test.
This change resets the pointer to position
0, 0at the beginning of the test so it is always in a known state when running.🔄 Types of changes
PR Type
Bug fix
Description
Fixes
test_touch_pointer_propertiesto reset pointer state.Adds pointer reset action to ensure test isolation.
Clears event state before running the test.
Changes walkthrough 📝
w3c_interaction_tests.py
Fix and enhance `test_touch_pointer_properties` setuppy/test/selenium/webdriver/common/w3c_interaction_tests.py