Skip to content

[java] timely get rid of the SelectorManager threads #11283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

joerg1985
Copy link
Member

Description

In cases where a lot of WebDrivers are created, timely closed and there is no GC done, a lot of SelectorManager threads are running. Calling the GC explicit is not best practice, but it is the only way to stop these threads.

Has been reported in #11270

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

In cases where a lot of WebDrivers are created, timely closed and there
is no GC done, a lot of SelectorManager threads are running. Calling the
GC explicit is not best practice, but it is the only way to stop these
threads.
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@titusfortner titusfortner added the C-java Java Bindings label Nov 28, 2022
@pujagani
Copy link
Contributor

pujagani commented Dec 1, 2022

The approach suggested here is not ideal since it manually calls GC. Closing in favor of #11345 which helps fix the same issue.

@pujagani pujagani closed this Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-java Java Bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants