[py]: remove deprecated find_element_by_ methods
#10712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## trunk #10712 +/- ##
==========================================
+ Coverage 46.64% 47.36% +0.71%
==========================================
Files 86 86
Lines 5855 5572 -283
Branches 278 278
==========================================
- Hits 2731 2639 -92
+ Misses 2846 2655 -191
Partials 278 278
Continue to review full report at Codecov.
|
AutomatedTester
approved these changes
Jun 8, 2022
|
Hello, |
|
For anyone who's in the process of updating their code, here are 16 find-and-replace strings that you can use: You'll also need to import |
evansd
added a commit
to bennettoxford/openprescribing
that referenced
this pull request
Dec 5, 2022
These are supported in Selenium 3 but become mandatory in Selenium 4. Helpful translation table: SeleniumHQ/selenium#10712 (comment)
|
It's a more maintainable API and more consistent with what the other implementations are doing. There's a lot of code in this repo to keep on top of, and we also like to have time to drink beer and eat curry. |
|
@titusfortner that's a perfectly understandable explanation. Thank you! Enjoy your beer and curry :) |
garoxas
added a commit
to garoxas/Scweet
that referenced
this pull request
Dec 11, 2022
Remove deprecated find_element_by_* and find_elements_by_* (SeleniumHQ/selenium#10712) Save images using original filename
longavailable
added a commit
to longavailable/practices
that referenced
this pull request
May 19, 2023
- Deprecated find_element_by_ methods in SeleniumHQ/selenium#10712 - DeprecationWarning: executable_path has been deprecated, please pass in a Service object in SeleniumHQ/selenium#9995 - Instead default chromedriver by [undetected-chromedriver](https://pypi.org/project/undetected-chromedriver, to fix https://stackoverflow.com/questions/59515561/this-browser-or-app-may-not-be-secure-error-while-attempting-to-login-in-to-gm
lhelwerd
added a commit
to grip-on-software/visualization-site
that referenced
this pull request
Jun 1, 2023
- Upgrade Python to 3.9 now that cffi provides musllinux packages - Upgrade Selenium standalone Chrome to 4.8.1 for newer ESM support - Run tests in verbose mode and update one Selenium import - Update find_elements?_by_.*(...) calls to find_elements?(By..., ...) since SeleniumHQ/selenium#10712 - Close driver during teardown even when there is no result outcome, to avoid keeping connections open for too long - Add remote connection timeout to detect connection issues earlier per SeleniumHQ/selenium#11596 - Remove some Python 2 import attempt - Axe report: Do not exit out if file does not exist - Adjust move_to_element_with_offset calls to work in center element, based on SeleniumHQ/selenium#11402 - Quit driver and set to None at teardown. This should properly close the session, allowing the connection to be reused for another test. - Update browser-sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is alright for
4.3now. Removal offind_element_by_methods throughout the python bindings. I don't think any tests where running through those but instead the correctfind_element|find_elements. Will grab fallout from CI if any occurs.Likely some
docsrelated fallout here, will address as I find it.