Skip to content

Conversation

symonk
Copy link
Member

@symonk symonk commented May 10, 2022

Some small tweaks & typing additions to webdriver.remote.webdriver.py. Mostly types and short hand ways of doing a few things

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2022

Codecov Report

Merging #10631 (e673170) into trunk (6b01d35) will increase coverage by 0.15%.
The diff coverage is 43.75%.

❗ Current head e673170 differs from pull request most recent head 3cad1d6. Consider uploading reports for the commit 3cad1d6 to get more accurate results

@@            Coverage Diff             @@
##            trunk   #10631      +/-   ##
==========================================
+ Coverage   45.60%   45.75%   +0.15%     
==========================================
  Files          86       86              
  Lines        5730     5728       -2     
  Branches      274      274              
==========================================
+ Hits         2613     2621       +8     
+ Misses       2843     2833      -10     
  Partials      274      274              
Impacted Files Coverage Δ
py/selenium/webdriver/remote/webdriver.py 41.61% <40.00%> (+1.44%) ⬆️
py/selenium/webdriver/remote/file_detector.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b01d35...3cad1d6. Read the comment docs.

@symonk symonk added the C-py Python Bindings label May 14, 2022
@titusfortner titusfortner added this to the 4.3 milestone May 24, 2022
@symonk symonk merged commit 7c92468 into SeleniumHQ:trunk Jun 9, 2022
@symonk symonk deleted the tidy-some-remote-webdriver-code branch June 9, 2022 12:56
elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
* [py] Tidy some remote webdriver code

* [py]: revert imports in remote webdriver; more types and tweaks

* [py]: Fix `flake8` violations in remote webdriver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-py Python Bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants