Docker: Move out step to fetch external jars for SessionMap from Base

[VietND96]

User description

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Reducing specific artifacts in Base layer.

Motivation and Context

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

---

PR Type

Enhancement

---

Description

• Move SessionMap external jar fetching from Base to Sessions Dockerfile

• Remove MVN_SELENIUM_VERSION and POSTGRESQL_VERSION from Base image

• Add specific build arguments to Sessions container build

• Optimize Docker layer separation for SessionMap dependencies

---

Diagram Walkthrough

flowchart LR
  Base["Base Dockerfile"] -- "Remove SessionMap jars" --> Sessions["Sessions Dockerfile"]
  Base -- "Remove build args" --> Makefile["Makefile"]
  Sessions -- "Add jar fetching" --> Dependencies["SessionMap Dependencies"]

Loading

File Walkthrough

	Relevant files
Enhancement	Dockerfile Remove SessionMap dependencies from base image                      Base/Dockerfile Remove MVN_SELENIUM_VERSION and POSTGRESQL_VERSION build arguments Remove SessionMap jar fetching logic from base image Remove .classpath_session_map.txt generation step +1/-10    Dockerfile Add SessionMap jar dependencies to Sessions image                Sessions/Dockerfile Add MVN_SELENIUM_VERSION and POSTGRESQL_VERSION build arguments Add jar fetching logic for SessionMap dependencies Generate .classpath_session_map.txt file in Sessions container +13/-0
Configuration changes	Makefile Update build arguments for sessions target                              Makefile Remove MVN_SELENIUM_VERSION build argument from base target Add MVN_SELENIUM_VERSION build argument to sessions target +3/-2

---

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Missing Validation The jar fetching logic assumes /tmp/cs exists but doesn't validate if MVN_SELENIUM_VERSION is provided. If the build argument is empty or null, the fetch command could fail silently or produce unexpected results. RUN if [ -f "/tmp/cs" ]; then \ java -jar /tmp/cs fetch --classpath --cache /external_jars \ org.seleniumhq.selenium:selenium-session-map-jdbc:${MVN_SELENIUM_VERSION} \ org.postgresql:postgresql:${POSTGRESQL_VERSION} \ org.seleniumhq.selenium:selenium-session-map-redis:${MVN_SELENIUM_VERSION} \ # Patch specific version for CVEs in the dependencies > /external_jars/.classpath_session_map.txt \ && chmod 664 /external_jars/.classpath_session_map.txt ; \ fi \ && rm -fr /root/.cache/* Error Handling The RUN command combines multiple operations with && but lacks proper error handling. If the jar fetching fails, the build might continue with incomplete dependencies, potentially causing runtime issues. RUN if [ -f "/tmp/cs" ]; then \ java -jar /tmp/cs fetch --classpath --cache /external_jars \ org.seleniumhq.selenium:selenium-session-map-jdbc:${MVN_SELENIUM_VERSION} \ org.postgresql:postgresql:${POSTGRESQL_VERSION} \ org.seleniumhq.selenium:selenium-session-map-redis:${MVN_SELENIUM_VERSION} \ # Patch specific version for CVEs in the dependencies > /external_jars/.classpath_session_map.txt \ && chmod 664 /external_jars/.classpath_session_map.txt ; \ fi \ && rm -fr /root/.cache/*

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Remove misplaced CVE comment The comment about patching CVE dependencies is misplaced and doesn't describe the actual command being executed. Remove or relocate this comment to accurately reflect what the command does. Sessions/Dockerfile [15-24] RUN if [ -f "/tmp/cs" ]; then \ java -jar /tmp/cs fetch --classpath --cache /external_jars \ org.seleniumhq.selenium:selenium-session-map-jdbc:${MVN_SELENIUM_VERSION} \ org.postgresql:postgresql:${POSTGRESQL_VERSION} \ org.seleniumhq.selenium:selenium-session-map-redis:${MVN_SELENIUM_VERSION} \ - # Patch specific version for CVEs in the dependencies > /external_jars/.classpath_session_map.txt \ && chmod 664 /external_jars/.classpath_session_map.txt ; \ fi \ && rm -fr /root/.cache/* Apply / Chat Suggestion importance[1-10]: 4 __ Why: The suggestion correctly identifies a potentially confusing comment within the RUN command, and its removal improves the Dockerfile's clarity.	Low
More