-
Notifications
You must be signed in to change notification settings - Fork 235
Bump holidays from 0.9.11 to 0.16 #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumps [holidays](https://github.com/dr-prodigy/python-holidays) from 0.9.11 to 0.16. - [Release notes](https://github.com/dr-prodigy/python-holidays/releases) - [Changelog](https://github.com/dr-prodigy/python-holidays/blob/master/CHANGES) - [Commits](dr-prodigy/python-holidays@v0.9.11...v.0.16) --- updated-dependencies: - dependency-name: holidays dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #623 +/- ##
=======================================
Coverage 77.96% 77.96%
=======================================
Files 123 123
Lines 8749 8749
=======================================
Hits 6821 6821
Misses 1928 1928
Flags with carried forward coverage won't be shown. Click here to find out more. |
@@ -12,7 +12,7 @@ def readme(): | |||
extras_require = { | |||
"prophet": [ | |||
"fbprophet>=0.5, <0.7", | |||
"holidays==0.9.11", | |||
"holidays==0.16", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to pin to 0.16
? Can we not just defer to holidays>=0.14.2
set by prophet
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @jklaise just realised this is a dependabot PR not yours! The question still stands though, can we just remove holidays
from our setup.py
now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, ignore me! This is what you've done in #627. We can probably just close this PR...
Closing as superseeded by #627. |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps holidays from 0.9.11 to 0.16.
Release notes
Sourced from holidays's releases.
... (truncated)
Changelog
Sourced from holidays's changelog.
... (truncated)
Commits
390f59c
v.0.16 (#716)d3dc700
v.0.15 (#691)1223874
v.0.14.25ea03af
v.0.14.1b859c5a
v.0.14.16e2a8a0
v.0.14.1ef2c14c
fix missing holidays.financial (#671)5492624
v0.14 (#668)7f44f0b
v0.142cf4b6c
include py.typed in published package (#662)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)