Add return_model to bulk_upsert #78
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bulk_insert
accepts areturn_model
parameter to be set toTrue
if the result to be returned should be a list of model instances (and not a list of dictionaries). However, the twobulk_upsert
methods defined in themanagers
module do not accept this parameter. So, the result is always a list of dictionaries and it is not possible to request a list of model instances.As a result, this pull request intends to change that by exposing a
return_model
parameter on thebulk_upsert
methods and pass it all the way tobulk_insert
.