Cope with foreign keys which are primary keys #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the assumption that all models have a field called 'id' and ensures that we use the correct column name for each field. Fixes SectorLabs#40.
PeterJCLaw
force-pushed
the
fix-foreign-primary-key-on-conflict-do-nothing
branch
from
d956b52 to
5f64e3a
Compare
|
Thanks for the contribution! This is definitely a change that should be merged. If you fix the failing test, then we're good to go from my end :-) |
This works around SectorLabs#43 where foreign keys cannot be expressed as objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the assumption that all models have a field called 'id' and ensures that we use the correct column name for each field.
This aims to fix #40.