Make time partition suffix customizable #200
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implementation attempt for #197
Usage example:
The change is fairly clean and it works, but design-wise I'm not sure if it is the right approach. Another possibility would be to add is as PostgresTimePartitionSize parameter, because the new parameter is "coupled to a specific size" (e.g. using
%Y_%m_%d
together withPostgresTimePartitionSize(months=1)
does not really make sense). That said,PostgresTimePartitionSize
is not responsible for naming, so 🤷♂️