fix(checkver): Remove redundant always-true condition in GitHub checkver logic

[z-Fng]

Motivation and Context

• Relates to fix(checkver): Use GitHub token from environment #4557
• Relates to [Feature] useGithubAPI by default when using github checkver #6559 (comment)

Description

Scoop/bin/checkver.ps1

Lines 159 to 163 in b588a06

	if ($json.checkver.github) {
	$url = $json.checkver.github.TrimEnd('/') + '/releases/latest'
	$regex = $githubRegex
	if ($json.checkver.PSObject.Properties.Count -eq 1) { $useGithubAPI = $true }
	}

The previous property count check was always true and had no effect. The always-true condition was misleading and confusing.
This change removes the redundant condition and explicitly enables the GitHub API for GitHub-based checkver.

$content = '{"checkver":{"github":"https://github.com/ScoopInstaller/Scoop","regex":"[\\d.]+"}}'
$json = ConvertFrom-Json $content
if ($json.checkver.PSObject.Properties.Count -eq 1) {Write-Host 'Condition passed'}
$json.checkver.PSObject.Properties.Count
$json.checkver | Get-Member -MemberType NoteProperty | Measure-Object | Select-Object -ExpandProperty Count

Checklist:

• I have read the Contributing Guide.
• I have ensured that I am targeting the develop branch.
• I have updated the documentation accordingly.
• I have updated the tests accordingly.
• I have added an entry in the CHANGELOG.

Summary by CodeRabbit

• Bug Fixes

  • GitHub-based version checks now consistently use the GitHub API, removing redundant conditional behavior for more reliable lookups.

• Documentation

  • Added an unreleased changelog entry noting the redundant-condition removal in the GitHub checkver flow.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The PR removes a redundant condition in GitHub checkver logic so that GitHub API usage is always enabled for manifest entries using checkver.github; the change affects bin/checkver.ps1 and adds a changelog entry.

Changes

Cohort / File(s)	Summary
Documentation CHANGELOG.md	Adds an Unreleased entry documenting the removal of an always-true condition in the GitHub checkver logic.
GitHub checkver logic bin/checkver.ps1	Removes the PSObject.Properties.Count conditional; useGithubAPI is now set to true whenever a manifest entry uses checkver.github, always routing through the GitHub API path.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Inspect bin/checkver.ps1 to confirm the removed condition was redundant and verify no other code relies on the previous branching.
• Check URL transformation and authorization code paths that execute when useGithubAPI is true for unintended side effects.
• Run or simulate checkver flows with different manifest shapes to ensure no regressions.

Suggested reviewers

• niheaven

Poem

🐰 I hopped through the branches, found a clause in the grass,
Always true and quite needless — I gave it a pass.
Now paths to GitHub hum clearly by night,
Simpler and cleaner, the logic feels light. ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title accurately describes the main change: removing a redundant always-true condition in the GitHub checkver logic, which matches the modifications in bin/checkver.ps1 and the CHANGELOG entry.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[z-Fng]

Perhaps we could avoid creating a separate changelog entry for this PR and instead use the same one as #6547?

checkver: Fix incorrect version returned when script fails without output (#6547)

[niheaven]

A separate entry is acceptable.