Merge FEATURE_wkt into main
#6537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Save crs_wkt, and update test outputs * Extra test fixes * What's new * Update tests. * What's New updates. * Correct use of mocking. --------- Co-authored-by: Will Benfold <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6537 +/- ##
==========================================
+ Coverage 89.93% 89.94% +0.01%
==========================================
Files 90 90
Lines 24166 24302 +136
Branches 4502 4546 +44
==========================================
+ Hits 21733 21859 +126
- Misses 1672 1674 +2
- Partials 761 769 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* Added ability to load multiple coordinate systems for a cube.
* Check for existence of grid_mapping attr
* Fix for failing tests for case where no coord systems found
* Some new tests for extended grid mapping `in test__grid_mappings.py`
* Added some validators to the grid_mapping parser
* Save cubes with multiple coord_systems using extended grid mapping syntax
* Typo in function name
* Ignore for ruff fmt
* More idiomatic list unpacking syntax
* Made return value of _parse_grid_mapping a dict. Added type hints.
* Added link to regex101 playground
* Refactored to store grid_mapping parsing results in CFReader.
* Small update to keep tests working with Mocks
* Changed cs_mapping to return dict of `{coord: cs}` rather than `{cs: [coords, ...]}`
* Added sorting of coordinates in grid mapping to saver. Also addes Future
flag for extended grid mapping saving.
* Fixed typo
* Removed redundant line
* Inverted conditional for clarity.
* MpPy type hinting.
* Use .get rather than indexing on engine.cube_parts
* Fix broken function signature
* Fix Mocks for Saver.py
* Changed grid_mappings to dict in saver.py
* Missing category keyword on warning.
* Removed Future flag and added Cube.ordered_axes property instead.
* Prefer use of `_get_coord_variable_name` over
* Updated URL to CF Conventions document
* Fixed spurious match group in extended grid mapping regex
* Ensure WKT is only written out if cube.ordered_axes=True
* Updated `Test_create_cf_grid_mapping` to test grid_mapping generation
with and without ordered coordinates.
* Revert Future tests.
* Use `_name_coord_map` to get coord var name
* Update _name_coord_map if no cfvar name found for coord
* Added some tests for multi-coordinate system saving
* Added assert on existence of coord system in test__grid_mappings.py
* Added multi coord system loading tests
* Only create CFGridMappingVariable if at least one referenced coord exists
* New CFParseError exception
* Move setting of ordered_axes property to loader.py + added tests.
* Removed the WKT attr from the CDL of some tests
* Remove expected WKT output from CDL of most tests.
* What's New
* Update Docs
* Renamed ordered_coords -> extended_grid_mapping and store as an attribute
* Fixed some typos and references to ordered_coords in latest.rst
* Expanded section in docs on mutliple coord systems
* Fixed emphasis split over two lines (sphinx doesn't like this)
* Small typo and emphasis fix
* Typo iris.coord.Coord => iris.coords.Coord
* Extended grid_mapping integration tests to test multi coord systems
* Revert unnecessary change to attr saving.
* Removed confusing coordinates entry in example CDL.
* Fixed rendering of latest.rst entry.
* Converted test_coord_systes.py::TestCoordSystem to pytest
* Updated remainder of test_coord_systems.py to pytest
* Removed context manager for tmp_path filename - deprecated in python3.13
* Fixed x and y variable data in multi_cs_osgb_wkt CDL.
* Modernised TestLoadMinimalGeostationary tests
---------
Co-authored-by: Martin Yeo <[email protected]>
trexfeathers
added
the
benchmark_this
⏱️ Performance Benchmark Report: e962419Performance shiftsFull benchmark resultsGenerated by GHA run |
ukmo-ccbunney
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge via merge-commit
(Not via squash-commit)