Allow derived coord references to be lazy. #6517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6517 +/- ##
=======================================
Coverage 89.89% 89.89%
=======================================
Files 90 90
Lines 24138 24138
Branches 4492 4492
=======================================
Hits 21699 21699
Misses 1679 1679
Partials 760 760 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bjlittle
approved these changes
Jul 8, 2025
pp-mo
added
the
benchmark_this
⏱️ Performance Benchmark Report: d69b0a7Performance shiftsFull benchmark resultsGenerated by GHA run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed during testing for #6404, and implementing solution #6515
The old code used
src.datawhen attaching a reference surface to a factory, but clearlysrc.core_data()makes a lot more sense, as a factory generally represents a "lazy" calculation anyway.Although worth considering a separate issue, I want to test this alongside a completed #6515 + be merged into that when it's clear it doesn't break it.
Hence WIP : intend to merge into #6515 when ready