Skip to content

update language detection #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public class ResponseToUserRoutingHandler : RoutingHandlerBase, IRoutingHandler
new ParameterPropertyDef("user_message_in_english",
"Translate user message from non-English to English"),
new ParameterPropertyDef("language",
"Language detected based on the latest message that USER sent, could be English, Spanish or Chinese.",
"User prefered language, considering the whole conversation. Language could be English, Spanish or Chinese.",
required: true),
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public class RouteToAgentRoutingHandler : RoutingHandlerBase, IRoutingHandler
new ParameterPropertyDef("user_message_in_english",
"Translate user message from non-English to English"),
new ParameterPropertyDef("language",
"Language detected based on the latest message that USER sent, could be English, Spanish or Chinese.",
"User prefered language, considering the whole conversation. Language could be English, Spanish or Chinese.",
required: true),
};

Expand Down
12 changes: 10 additions & 2 deletions src/Infrastructure/BotSharp.Core/Translation/TranslationService.cs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using Amazon.Runtime.Internal.Transform;
using BotSharp.Abstraction.Options;
using BotSharp.Abstraction.Templating;
using BotSharp.Abstraction.Translation;
using BotSharp.Abstraction.Translation.Attributes;
using Newtonsoft.Json;
using System.Reflection;
Expand Down Expand Up @@ -28,16 +29,23 @@ public async Task<T> Translate<T>(Agent router, string messageId, T data, string
{
_router = router;
_messageId = messageId;

var unique = new HashSet<string>();
Collect(data, ref unique);
if (unique.Count == 0)
{
return data;
}

var cloned = data;
if (clone)
{
cloned = Clone(data);
}

var unique = new HashSet<string>();
Collect(cloned, ref unique);
var map = await InnerTranslate(unique, language);
cloned = Assign(cloned, map);

return cloned;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@ Expected user goal agent is {{ expected_user_goal_agent }}.
{%- else -%}
User goal agent is inferred based on user initial request.
{%- endif %}
Detect language based on the overall content in [CONVERSATION] and only include user message.