solve RoutingSpeeder path issue #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oceania2018
reviewed
Sep 12, 2023
| @@ -24,9 +25,17 @@ public RoutingSpeederController(IServiceProvider service) | |||
| public IActionResult TrainIntentClassifier(TrainingParams trainingParams) | |||
| { | |||
| var intentClassifier = _service.GetRequiredService<IntentClassifier>(); | |||
| intentClassifier.InitClassifer(trainingParams.Inference); | |||
| // intentClassifier.InitClassifer(trainingParams.Inference); | |||
There was a problem hiding this comment.
Should we comment this for training?
There was a problem hiding this comment.
The InitClassifer will call LoadWeights method. If we still want to re-train model when some weights exist, calling this method will load that weights first and then continue training.
Oceania2018
reviewed
Sep 12, 2023
| intentClassifier.Train(trainingParams); | ||
| return Ok(intentClassifier.Labels); | ||
| } | ||
|
|
||
| [HttpPost("/routing-speeder/classifier/inference")] |
There was a problem hiding this comment.
Is this API for train or inference?
The function name doesn't match with endpoint.
Oceania2018
reviewed
Sep 12, 2023
| { | ||
| _model.load_weights(weightsFile); | ||
| _isModelReady = true; | ||
| Console.WriteLine($"Successfully load the weights!"); | ||
| } | ||
| else | ||
| { | ||
| var logInfo = inference ? "No available weights." : "Will implement model training process and write trained weights into local"; | ||
| var logInfo = _inferenceMode ? "No available weights." : "Will implement model training process and write trained weights into local"; | ||
| _isModelReady = false; | ||
| Console.WriteLine(logInfo); |
There was a problem hiding this comment.
Please use _logger.info instead of Console.WriteLine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.