Skip to content
This repository was archived by the owner on May 15, 2025. It is now read-only.

Itp method #69

Merged
merged 21 commits into from
Jul 18, 2023
Merged

Itp method #69

merged 21 commits into from
Jul 18, 2023

Conversation

yash2798
Copy link
Member

@yash2798 yash2798 commented Jul 13, 2023

reopening the pr as the previous ci tests were failing.

Tackles issue #184

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #69 (1e4eb4b) into main (f20f5e4) will decrease coverage by 0.24%.
The diff coverage is 89.83%.

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   92.01%   91.78%   -0.24%     
==========================================
  Files          20       21       +1     
  Lines         952     1010      +58     
==========================================
+ Hits          876      927      +51     
- Misses         76       83       +7     
Impacted Files Coverage Δ
src/itp.jl 89.65% <89.65%> (ø)
src/SimpleNonlinearSolve.jl 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yash2798
Copy link
Member Author

@ChrisRackauckas the ci tests miraculously passed here.

@yash2798
Copy link
Member Author

@ChrisRackauckas This one is also ready for review in case you missed it?

@ChrisRackauckas
Copy link
Member

I made a few last edits, this looks good to go.

@ChrisRackauckas ChrisRackauckas merged commit 491a632 into SciML:main Jul 18, 2023
@oscardssmith
Copy link
Member

I realize this is post merge, but since ITP is an acronym, should it be ITP rather than Itp?

@ChrisRackauckas
Copy link
Member

Yes, make a PR. We can do a quick patch on that.

@oscardssmith
Copy link
Member

#71

@yash2798 yash2798 deleted the ys/itp branch July 18, 2023 23:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants