Skip to content

fix MooncakeOriginator #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025
Merged

fix MooncakeOriginator #1167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ext/DiffEqBaseChainRulesCoreExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,21 +13,21 @@ ChainRulesCore.@non_differentiable DiffEqBase.checkkwargs(kwargshandle)

function ChainRulesCore.frule(::typeof(DiffEqBase.solve_up), prob,
sensealg::Union{Nothing, AbstractSensitivityAlgorithm},
u0, p, args...;
u0, p, args...; originator = SciMLBase.ChainRulesOriginator(),
kwargs...)
DiffEqBase._solve_forward(
prob, sensealg, u0, p,
set_mooncakeoriginator_if_mooncake(SciMLBase.ChainRulesOriginator()), args...;
originator, args...;
kwargs...)
end

function ChainRulesCore.rrule(::typeof(DiffEqBase.solve_up), prob::AbstractDEProblem,
sensealg::Union{Nothing, AbstractSensitivityAlgorithm},
u0, p, args...;
u0, p, args...; originator = SciMLBase.ChainRulesOriginator(),
kwargs...)
DiffEqBase._solve_adjoint(
prob, sensealg, u0, p,
set_mooncakeoriginator_if_mooncake(SciMLBase.ChainRulesOriginator()), args...;
originator, args...;
kwargs...)
end

Expand Down
23 changes: 18 additions & 5 deletions ext/DiffEqBaseMooncakeExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,12 @@ module DiffEqBaseMooncakeExt

using DiffEqBase, Mooncake
using DiffEqBase: SciMLBase
using SciMLBase: ADOriginator, MooncakeOriginator
Mooncake.@from_rrule(Mooncake.MinimalCtx,
using SciMLBase: ADOriginator, ChainRulesOriginator, MooncakeOriginator
import Mooncake: rrule!!, CoDual, zero_fcodual, @is_primitive,
@from_rrule, @zero_adjoint, @mooncake_overlay, MinimalCtx,
NoPullback

@from_rrule(MinimalCtx,
Tuple{
typeof(DiffEqBase.solve_up),
DiffEqBase.AbstractDEProblem,
Expand All @@ -15,7 +19,7 @@ Mooncake.@from_rrule(Mooncake.MinimalCtx,
true,)

# Dispatch for auto-alg
Mooncake.@from_rrule(Mooncake.MinimalCtx,
@from_rrule(MinimalCtx,
Tuple{
typeof(DiffEqBase.solve_up),
DiffEqBase.AbstractDEProblem,
Expand All @@ -25,7 +29,16 @@ Mooncake.@from_rrule(Mooncake.MinimalCtx,
},
true,)

Mooncake.@zero_adjoint Mooncake.MinimalCtx Tuple{typeof(DiffEqBase.numargs), Any}
Mooncake.@mooncake_overlay DiffEqBase.set_mooncakeoriginator_if_mooncake(x::ADOriginator) = MooncakeOriginator
@zero_adjoint MinimalCtx Tuple{typeof(DiffEqBase.numargs), Any}
@is_primitive MinimalCtx Tuple{
typeof(DiffEqBase.set_mooncakeoriginator_if_mooncake), SciMLBase.ChainRulesOriginator
}

function rrule!!(
f::CoDual{typeof(DiffEqBase.set_mooncakeoriginator_if_mooncake)},
X::CoDual{SciMLBase.ChainRulesOriginator}
)
return zero_fcodual(SciMLBase.MooncakeOriginator()), NoPullback(f, X)
end

end
21 changes: 18 additions & 3 deletions src/solve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1174,14 +1174,29 @@ function solve(prob::NonlinearProblem, args...; sensealg = nothing,
p = p !== nothing ? p : prob.p

if wrap isa Val{true}
wrap_sol(solve_up(prob, sensealg, u0, p, args...; alias_u0 = alias_u0, kwargs...))
wrap_sol(solve_up(prob,
sensealg,
u0,
p,
args...;
alias_u0 = alias_u0,
originator = set_mooncakeoriginator_if_mooncake(SciMLBase.ChainRulesOriginator()),
kwargs...))
else
solve_up(prob, sensealg, u0, p, args...; alias_u0 = alias_u0, kwargs...)
solve_up(prob,
sensealg,
u0,
p,
args...;
alias_u0 = alias_u0,
originator = set_mooncakeoriginator_if_mooncake(SciMLBase.ChainRulesOriginator()),
kwargs...)
end
end

function solve_up(prob::Union{AbstractDEProblem, NonlinearProblem}, sensealg, u0, p,
args...; kwargs...)
args...; originator = SciMLBase.ChainRulesOriginator(),
kwargs...)
alg = extract_alg(args, kwargs, has_kwargs(prob) ? prob.kwargs : kwargs)
if isnothing(alg) || !(alg isa AbstractDEAlgorithm) # Default algorithm handling
_prob = get_concrete_problem(prob, !(prob isa DiscreteProblem); u0 = u0,
Expand Down
Loading