Skip to content
This repository was archived by the owner on Jan 27, 2020. It is now read-only.

add publishDirMode param and docs#671

Merged
maxulysse merged 2 commits intoSciLifeLab:devfrom
maxulysse:Publish
Oct 24, 2018
Merged

add publishDirMode param and docs#671
maxulysse merged 2 commits intoSciLifeLab:devfrom
maxulysse:Publish

Conversation

@maxulysse
Copy link
Member

@maxulysse maxulysse commented Oct 23, 2018 •
edited
Loading

PR checklist

  • PR is made against dev branch
  • This comment contains a description of changes (with reason)
  • Ensure the test suite passes (./scripts/test.sh -p docker -t ALL).
  • Documentation in docs is updated
  • CHANGELOG.md is updated

@maxulysse maxulysse requested a review from apeltzer October 23, 2018 12:42
apeltzer
apeltzer approved these changes Oct 23, 2018
View reviewed changes
Copy link
Collaborator

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you :-)

@maxulysse maxulysse merged commit 5ef1dec into SciLifeLab:dev Oct 24, 2018
@maxulysse maxulysse deleted the Publish branch October 24, 2018 11:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alneberg alneberg Awaiting requested review from alneberg

@szilvajuhos szilvajuhos Awaiting requested review from szilvajuhos

1 more reviewer

@apeltzer apeltzer apeltzer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maxulysse @apeltzer