This repository was archived by the owner on Jan 27, 2020. It is now read-only.
2 threads and 2 cpus for each FastQC process#632
Merged
maxulysse merged 1 commit intoSciLifeLab:masterfrom Sep 4, 2018
Merged
Conversation
Member
Author
|
The tests pass on travis and on rackham so should be fine. Still have some issues running it on the mac, but that is probably not related to this issue. |
Closed
jherrero
referenced
this pull request
in UCL-BLIC/Sarek_v2.2.1
Apr 11, 2019
2 threads and 2 cpus for each FastQC process
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the execution of FastQC so that it uses one thread per fastq file as described in #631.
PR checklist
./scripts/test.sh -p docker -t ALL).Tests do not pass. But I highly suspect that is due to my personal setup for some reason. Travis checks should give a final decision.