-
Notifications
You must be signed in to change notification settings - Fork 30
feat: templated external links (draft) #2097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: templated external links (draft) #2097
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IT can be approved after fixing the linting and adding some API testing.
Also I would check if dataset schema to obsolete dto works correctly
// This data is not represented in Mongoose. | ||
// It is generated internally based on the user-defined link templates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what this comments means?
Can it be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've modified the comment somewhat. It explains why a class without schema annotations is in the schema folder.
It does, though I had to add Looks like the current-to-obsolete conversion is the only code that uses |
…ss to the injected configuration.
… function in the Dataset service.
…). Referencing it as one in the APIs causes a validation failure, which prevents the SDK from compiling. I assume this is a new error caused by some package upgrade that made validation more precise.
Description
Add a field for generating dataset links based on admin-configured templates.
See #689 for details.
This has a companion PR for the front end: SciCatProject/frontend#1910 .
Motivation
We get a lot of requests from users and researchers to provide a variety of different types of web-based tools that related directly to datasets. These can be pages that display visualization, pages that provide analysis tools (including AI/ML) and jupyter notebooks on particular JupyterHub instance. In all cases, we would want to take the user to the page with the dataset in context.
Fixes
Changes:
Tests included
Documentation
official documentation info