fix: improve error messages for misconfigured job actions #2051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbliven
changed the title
sbliven
changed the title
sbliven
changed the title
sbliven
force-pushed
the
switch-error-message
branch
from
52cb3b3 to
eb2f0fe
Compare
sbliven
changed the title
despadam
approved these changes
Jul 15, 2025
Junjiequan
force-pushed
the
switch-error-message
branch
from
eb2f0fe to
4f43825
Compare
All actions now dump their options if options are invalid, making it easier to track down bugs.
Junjiequan
force-pushed
the
switch-error-message
branch
from
4f43825 to
be36286
Compare
|
Thanks @Junjiequan for fixing the tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The error message for misconfigured
switchactions in jobConfig.yaml was copy-pasted from the validate action. This updates it to clarify the source of the error. Similar errors for other job actions have also been updated to be consistent.Motivation
We ran into such an error in paulscherrerinstitute/scicat-ci#285.
Fixes
Changes:
Tests included
Documentation
official documentation info