fix: update ownerUser, ownerGroup logic for v3 job creation #1913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 21, 2025
sbliven
requested changes
May 23, 2025
sbliven
approved these changes
May 28, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 3, 2025
<!-- Follow semantic-release guidelines for the PR title, which is used in the changelog. Title should follow the format `<type>(<scope>): <subject>`, where - Type is one of: build|chore|ci|docs|feat|fix|perf|refactor|revert|style|test|BREAKING CHANGE - Scope (optional) describes the place of the change (eg a particular milestone) and is usually omitted - subject should be a non-capitalized one-line description in present imperative tense and not ending with a period See https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#-git-commit-guidelines for more details. --> ## Description <!-- Short description of the pull request --> - #1954 - #1913 - #1931 - #1934 ## Motivation <!-- Background on use case, changes needed --> - #1937 - #1776 (topic 2) - #1927 ## Fixes <!-- Please provide a list of the issues fixed by this PR --> ## Changes: <!-- Please provide a list of the changes implemented by this PR --> ## Tests included - [ ] Included for each change/fix? - [ ] Passing? <!-- Merge will not be approved unless tests pass --> ## Documentation - [ ] swagger documentation updated (required for API changes) - [ ] official documentation updated ### official documentation info <!-- If you have updated the official documentation, please provide PR # and URL of the updated pages -->
totopoloco
pushed a commit
that referenced
this pull request
Jun 16, 2025
* update ownerUser, ownerGroup logic * fix some tests * update tests * tests done * fixes after review * last fixes * fix lint error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating
src/jobs/interceptors/create-job-v3-mapping.interceptor.tsfor improved backwards compatibility.Motivation
#1776 (topic 2)
Fixes
Changes:
usernameis not provided injobParams(v3 dto) then we assign the jobs to the currently signed in user.ownerGroupis not provided injobParams(v3 dto) then, depending on the job auth configuration:#datasetOwnerwe retrieve the ownerGroup of the first dataset indatasetList, since for this job config all chosen datasets should have the same ownerGroup as the job.#datasetAccesswe pick the first common group of both accessGroups and ownerGroups of all chosen datasetsTests included
Documentation
official documentation info
SciCatProject/documentation#74