Skip to content

fix(jobs): use updated SDK #1881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025
Merged

fix(jobs): use updated SDK #1881

merged 2 commits into from
Jun 4, 2025

Conversation

despadam
Copy link
Member

@despadam despadam commented Jun 3, 2025

Description

Release v4.17.1 updated the SDK to fix issue SciCatProject/scicat-backend-next#1937

We now need to call the correct methods in the frontend.

Motivation

#1858

Fixes:

Use jobsControllerCreateV3() instead of jobsControllerCreateV3V3()

Changes:

  • src/app/state-management/effects/jobs.effects.ts
  • src/app/state-management/effects/jobs.effects.spec.ts

Tests included

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)

Documentation

  • swagger documentation updated [required]
  • official documentation updated [nice-to-have]

official documentation info

If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included

Backend version

  • Does it require a specific version of the backend
  • which version of the backend is required:

Summary by Sourcery

Align job effects with updated SciCat SDK by replacing deprecated V3V3 methods with V3 variants and bumping the SDK dependency.

Bug Fixes:

  • Replace calls to jobsControllerFindAllV3V3, jobsControllerFindOneV3V3, and jobsControllerCreateV3V3 with jobsControllerFindAllV3, jobsControllerFindOneV3, and jobsControllerCreateV3 to match the updated SDK.

Build:

  • Bump @scicatproject/scicat-sdk-ts-angular dependency from v4.17.0 to v4.17.1.

Tests:

  • Update jobs.effects.spec.ts to mock and expect the new V3 SDK method names.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @despadam - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Collaborator

@martin-trajanovski martin-trajanovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better by cleaning up the double version suffix. 💯

@despadam despadam merged commit 6767522 into master Jun 4, 2025
8 checks passed
@despadam despadam deleted the 1858-updated-sdk-jobsservice branch June 4, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants