Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
lina1919
reviewed
Aug 8, 2023
Comment on lines
+42
to
+51
| public ResponseEntity<ApiResponse<Object>> signOut(@RequestBody AccessTokenDto requestDto) { | ||
| AccessTokenDto resDto = authService.signOut(requestDto); | ||
| ResponseCookie responseCookie = removeRefreshTokenCookie(); | ||
|
|
||
| return ResponseEntity.ok() | ||
| .header(SET_COOKIE, responseCookie.toString()) | ||
| .body(resDto); | ||
| .body(ApiResponse.builder() | ||
| .status(ApiResponseStatus.SUCCESS) | ||
| .data(resDto) | ||
| .build()); |
Contributor
There was a problem hiding this comment.
그때 이야기 했듯이 이 부분은 프론트 측에 슬랙으로 알려주면 좋을 것 같아요!
lina1919
approved these changes
Aug 8, 2023
Contributor
lina1919
left a comment
lina1919
left a comment
There was a problem hiding this comment.
LGTM! 수고많으셨습니다 merge 하시죠
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 개요
작업 분류
작업 상세 내용
성공 시 status (SUCCESS) , data 형식을 리턴
실패 시 status (FAIL), data 형식을 리턴
ErrorResponse도 API 응답 포맷대로 리턴하도록 GlobalExceptionHandler에서 처리했습니다.
현재 생성된 API에는 모두 공통 응답 포맷을 적용하였습니다.
생각해볼 문제