feat(lint): Adopt oxlint type-aware linting #1941
Open
+225
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade oxlint from 1.28.0 to 1.33.0 for type-aware linting support - Upgrade eslint-plugin-oxlint from 1.28.0 to 1.33.0 for compatibility - Add oxlint-tsgolint 0.9.1 as peer dependency for type-aware features Rationale: oxlint 1.33.0 introduces alpha support for type-aware linting rules which can replace several typescript-eslint rules with ~10x faster performance. The oxlint-tsgolint companion package provides the TypeScript type information needed for type-aware rule execution.
- Enable --type-aware flag in pretest and nano-staged scripts - Configure type-aware rules in .oxlintrc.json: - Enable: await-thenable, no-floating-promises, no-misused-promises - Disable overly strict rules for this codebase - Add overrides to allow floating promises in integration tests - Disable migrated rules in ESLint to avoid duplicate checking Rationale: Type-aware linting rules like no-floating-promises and await-thenable catch common async/await mistakes at lint time. By running these through oxlint instead of typescript-eslint, we get ~10x faster lint performance while maintaining the same safety guarantees.
- Add type-aware rules: no-deprecated, prefer-includes, no-for-in-array, no-implied-eval, require-array-sort-compare, no-base-to-string, no-array-delete, only-throw-error, no-redundant-type-constituents, no-meaningless-void-operator, no-unsafe-enum-comparison, no-mixed-enums, switch-exhaustiveness-check, restrict-plus-operands, prefer-promise-reject-errors - Disable 13 corresponding ESLint rules to avoid duplicate checking Rationale: These additional type-aware rules catch common TypeScript mistakes at lint time with ~10x faster performance than typescript-eslint equivalents. All rules pass with 0 errors on the current codebase.
- Enable no-unsafe-type-assertion, no-unnecessary-type-assertion, restrict-template-expressions, and unbound-method rules globally - Add targeted overrides for legitimate type assertion patterns: - Test files: disable assertion rules for test utilities - Integration tests: disable floating promises for test patterns - Core packages: disable unsafe assertions for generic type patterns - Disable corresponding ESLint rules (unbound-method, etc.) - Remove redundant ESLint test file override (now handled by oxlint) Rationale: Strict type assertion rules catch unsafe casts at lint time. Targeted overrides allow intentional patterns in tests and core generic implementations while enforcing safety in application code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adopts oxlint's new type-aware linting feature (alpha) to replace typescript-eslint rules with ~10x faster performance.
Changes:
--type-awareflag in lint scriptsawait-thenable,no-floating-promises,no-misused-promisesno-deprecated,prefer-includes,no-for-in-array, etc.no-unsafe-type-assertion,no-unnecessary-type-assertion,restrict-template-expressions,unbound-methodCommits:
chore(deps): Upgrade oxlint to 1.33.0 and add oxlint-tsgolintfeat(lint): Adopt type-aware linting with oxlint (basic 3 rules)feat(lint): Enable 15 additional type-aware rulesfeat(lint): Enable strict type assertion rules with targeted overridesTest plan
yarn pretestpasses with 0 errorsyarn testpasses (all 282 tests)