fix(core,platform): table navigatable rows #6357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for fundamental-ngx ready! 🔨 Explore the source changes: 537beff 🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-ngx/deploys/612723110cfc9f00077f2e61 😎 Browse the preview: https://deploy-preview-6357--fundamental-ngx.netlify.app |
platon-rov
force-pushed
the
fix/table-navigation
branch
from
bc3e980 to
c99a9cb
Compare
platon-rov
changed the title
Smiranin
reviewed
Aug 19, 2021
...docs/src/app/core/component-docs/table/examples/table-navigatable-row-example.component.html
Outdated
Show resolved
Hide resolved
...-table/platform-table-examples/platform-table-navigatable-row-indicator-example.component.ts
Outdated
Show resolved
Hide resolved
Betrozov
approved these changes
Aug 20, 2021
|
This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days |
dimamarksman
approved these changes
Aug 23, 2021
Smiranin
approved these changes
Aug 23, 2021
platon-rov
force-pushed
the
fix/table-navigation
branch
from
103a7fa to
537beff
Compare
platon-rov
changed the title
platon-rov
added a commit
that referenced
this pull request
Aug 29, 2021
This reverts commit 97d6f3c
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
Closes #6358.
Please provide a brief summary of this pull request.
BREAKING CHANGE
The previously implemented navigatable table rows feature needs to be adjusted a bit because of:
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
Documentation checklist:
README.md