feat(core): implement datetime formatter pipes #5502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for fundamental-ngx ready! 🔨 Explore the source changes: e756716 🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-ngx/deploys/60bfd25f1e41330008b0d38d 😎 Browse the preview: https://deploy-preview-5502--fundamental-ngx.netlify.app |
Betrozov
suggested changes
May 27, 2021
InnaAtanasova
changed the title
|
Closing old PRs - feel free to reopen it if/when needed |
N1XUS
suggested changes
Jun 7, 2021
...ocs/src/app/core/component-docs/date-picker/examples/date-picker-format-example.component.ts
Outdated
Show resolved
Hide resolved
N1XUS
suggested changes
Jun 7, 2021
...docs/datetime-picker/examples/datetime-format-example/datetime-format-example.component.html
Outdated
Show resolved
Hide resolved
|
@mikerodonnell89 please fix Travis CI failing build |
Betrozov
approved these changes
Jun 7, 2021
N1XUS
approved these changes
Jun 8, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5499
Please provide a brief summary of this pull request.
Introduces 3 new pipes for formatting dates based up on the dates provided to
DATE_TIME_FORMATSby the developer.dateFormatPipeformats datesdateTimeFormatPipeformats datetimesdateFromNowPipecan potentially be used to display how much time has passed since a date - this is currently not implemented with the default DATE_TIME_FORMATS/FdDateTimeAdapter but will be easy to add to the adapter when using moment.js or some similar library.This does introduce a breaking change. Optional
fromNowfunction was added to the DatetimeAdapter abstract class. Because there are no truly "optional" abstract functions, any adapter that implements the DatetimeAdapter will need to implement thefromNowfunction - however if the developer does not wish to use thefromNowfunction, in their custom adapter they can simply implement it asfromNow: undefinedas I've done here for the default FdDatetimeAdapterPlease check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
Documentation checklist:
README.md