-
Notifications
You must be signed in to change notification settings - Fork 70
[EDOI] Add new object types EDOI #681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
a8ec8b7
Add files for EDOI & EDOT
i506210 499d83a
React to abaplint
i506210 e1e96b2
React to abaplint
i506210 ecdefa0
Merge branch 'main' into feature/edoi
i506210 3a2e9b9
React to comments from Michael Schneider
i506210 6b8c5b2
reaction to comments
i506210 a158a2a
Merge branch 'main' into feature/edoi
i506210 2759148
corrections
i506210 bbc4f1b
corrections
i506210 1e192f0
Merge branch 'main' into feature/edoi
i506210 63a1453
correction
i506210 167be48
corrections
i506210 dedf71f
correction
i506210 47369f3
corrections
i506210 3a1ecf4
correction
i506210 fdc3759
Merge branch 'main' into feature/edoi
schneidermic0 c7e09f2
changes with example
i506210 a76b5ff
changes with example
i506210 c6add98
changes with example
i506210 39bee5a
changes with example
i506210 ab5807a
corrections
i506210 0133e0d
Merge branch 'main' into feature/edoi
wurzka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # EDOI File Format | ||
|
|
||
| File | Cardinality | Definition | Schema | Example | ||
| :--- | :--- | :--- | :--- | :--- | ||
| `<name>.edoi.json` | 1 | [`zif_aff_edoi_v1.intf.abap`](./type/zif_aff_edoi_v1.intf.abap) | [`edoi-v1.json`](./edoi-v1.json) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,207 @@ | ||
| { | ||
| "$comment": "This file is autogenerated, do not edit manually, see https://github.com/SAP/abap-file-formats for more information.", | ||
| "$schema": "https://json-schema.org/draft/2020-12/schema", | ||
| "$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/edoi/edoi-v1.json", | ||
| "title": "eDocument Interface", | ||
| "description": "eDocument Interface", | ||
| "type": "object", | ||
| "properties": { | ||
| "formatVersion": { | ||
| "title": "Format Version", | ||
| "description": "Format version", | ||
| "type": "string", | ||
| "const": "1" | ||
| }, | ||
| "header": { | ||
| "title": "Header", | ||
| "description": "Header", | ||
| "type": "object", | ||
| "properties": { | ||
| "description": { | ||
| "title": "Description", | ||
| "description": "Description of the ABAP object", | ||
| "type": "string", | ||
| "maxLength": 60 | ||
| }, | ||
| "originalLanguage": { | ||
| "title": "Original Language", | ||
| "description": "Original language of the ABAP object", | ||
| "type": "string", | ||
| "minLength": 2 | ||
| }, | ||
| "abapLanguageVersion": { | ||
| "title": "ABAP Language Version", | ||
| "description": "ABAP language version", | ||
| "type": "string", | ||
| "enum": [ | ||
| "standard", | ||
| "keyUser", | ||
| "cloudDevelopment" | ||
| ], | ||
| "enumTitles": [ | ||
| "Standard", | ||
| "ABAP for Key Users", | ||
| "ABAP Cloud Development" | ||
| ], | ||
| "enumDescriptions": [ | ||
| "Standard", | ||
| "ABAP for key user extensibility", | ||
| "ABAP cloud development" | ||
| ], | ||
| "default": "standard" | ||
| } | ||
| }, | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "description", | ||
| "originalLanguage" | ||
| ] | ||
| }, | ||
| "generalInformation": { | ||
| "title": "eDocument Interface", | ||
| "description": "eDocument Interface", | ||
| "type": "object", | ||
| "properties": { | ||
| "edocumentInterfaceId": { | ||
| "title": "eDocument Interface", | ||
| "description": "eDocument Interface", | ||
| "type": "string", | ||
| "maxLength": 30 | ||
| }, | ||
| "interfaceDescription": { | ||
| "title": "eDocument Interface Description", | ||
| "description": "Interface Description.", | ||
| "type": "string", | ||
| "maxLength": 100 | ||
| }, | ||
| "interfaceDirection": { | ||
| "title": "eDocument Interface Direction", | ||
| "description": "Interface Direction.", | ||
| "type": "string", | ||
| "enum": [ | ||
| "outbound", | ||
| "inbound" | ||
| ], | ||
| "enumTitles": [ | ||
| "Outbound", | ||
| "Inbound" | ||
| ], | ||
| "enumDescriptions": [ | ||
| "Outbound", | ||
| "Inbound" | ||
| ], | ||
| "default": "outbound" | ||
| }, | ||
| "edocumentInterfaceVersion": { | ||
| "title": "Interface Version", | ||
| "description": "Interface Version", | ||
| "type": "array", | ||
| "uniqueItems": true, | ||
| "items": { | ||
| "title": "Interface Version", | ||
| "description": "eDocument Interface Version", | ||
| "type": "object", | ||
| "properties": { | ||
| "intVersion": { | ||
| "title": "Interface Version", | ||
| "description": "Interface Version", | ||
| "type": "string", | ||
| "maxLength": 4 | ||
| }, | ||
| "intVersionDesc": { | ||
| "title": "Interface Version Description", | ||
| "description": "Interface Version Description", | ||
| "type": "string", | ||
| "maxLength": 30 | ||
| }, | ||
| "activeFrom": { | ||
| "title": "Active From", | ||
| "description": "Active from", | ||
| "type": "string", | ||
| "format": "date-time" | ||
| } | ||
| }, | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "intVersion", | ||
| "intVersionDesc", | ||
| "activeFrom" | ||
| ] | ||
| } | ||
| }, | ||
| "edocSpecAdditionalTable": { | ||
| "title": "Attribute Determination for Communication with Cloud Edition", | ||
| "description": "DRC Integration Attribute Determination", | ||
| "type": "array", | ||
| "uniqueItems": true, | ||
| "items": { | ||
| "title": "Attribute Determination for Communication with Cloud Edition", | ||
| "description": "DRC Integration Attribute Determination", | ||
| "type": "object", | ||
| "properties": { | ||
| "processType": { | ||
| "title": "Process Type", | ||
| "description": "DRC Process Type", | ||
| "type": "string", | ||
| "maxLength": 50 | ||
| }, | ||
| "processVersion": { | ||
| "title": "Process Version", | ||
| "description": "DRC Process Version", | ||
| "type": "string", | ||
| "maxLength": 20 | ||
| }, | ||
| "processSubtype": { | ||
| "title": "Process Subtype", | ||
| "description": "DRC Process Subtype", | ||
| "type": "string", | ||
| "maxLength": 50 | ||
| }, | ||
| "drcAction": { | ||
| "title": "Action", | ||
| "description": "DRC Process Action", | ||
| "type": "string", | ||
| "maxLength": 30 | ||
| }, | ||
| "respInterfaceId": { | ||
| "title": "Response Interface", | ||
| "description": "eDoc Response Interface", | ||
| "type": "string", | ||
| "maxLength": 30 | ||
| }, | ||
| "respIntVersion": { | ||
| "title": "Response Interface Version", | ||
| "description": "Response Interface Version", | ||
| "type": "string", | ||
| "maxLength": 4 | ||
| } | ||
| }, | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "processType", | ||
| "processVersion", | ||
| "processSubtype", | ||
| "drcAction", | ||
| "respInterfaceId", | ||
| "respIntVersion" | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "edocumentInterfaceId", | ||
| "interfaceDescription", | ||
| "interfaceDirection", | ||
| "edocumentInterfaceVersion", | ||
| "edocSpecAdditionalTable" | ||
| ] | ||
| } | ||
| }, | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "formatVersion", | ||
| "header", | ||
| "generalInformation" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,120 @@ | ||
| INTERFACE zif_aff_edoi_v1 PUBLIC. | ||
|
|
||
| "! <p class="shorttext">Interface direction</p> | ||
| "! Interface direction | ||
| "! $required | ||
| "! $values {@link zif_aff_edoi_v1.data:co_edoc_int_direction} | ||
| "! $default {@link zif_aff_edoi_v1.data:co_edoc_int_direction.outbound} | ||
Markus1812 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| TYPES ty_int_direction TYPE c LENGTH 1. | ||
| TYPES: | ||
| "! <p class="shorttext">Interface Version</p> | ||
| "! eDocument Interface Version | ||
| BEGIN OF ty_edoc_interface_version, | ||
| "! <p class="shorttext">Interface Version</p> | ||
| "! Interface Version | ||
| "! $required | ||
| int_version TYPE c LENGTH 4, | ||
schneidermic0 marked this conversation as resolved.
Show resolved
Hide resolved
GuilhermeSaraiva96 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "! <p class="shorttext">Interface Version Description</p> | ||
| "! Interface Version Description | ||
| "! $required | ||
| int_version_desc TYPE c LENGTH 30, | ||
GuilhermeSaraiva96 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "! <p class="shorttext">Active From</p> | ||
| "! Active from | ||
| "! $required | ||
| active_from TYPE sy-datum, | ||
|
|
||
| END OF ty_edoc_interface_version. | ||
| "! <p class="shorttext">Interface Versions</p> | ||
| "! eDocument Interface Versions | ||
| TYPES ty_edoc_interface_versions TYPE SORTED TABLE OF ty_edoc_interface_version WITH UNIQUE KEY int_version. | ||
| TYPES: | ||
| "! <p class="shorttext">Attribute Determination for Communication with Cloud Edition</p> | ||
| "! DRC Integration Attribute Determination | ||
| BEGIN OF ty_edoc_int_drc_attr, | ||
i506210 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "! <p class="shorttext">Process Type</p> | ||
| "! DRC Process Type | ||
| "! $required | ||
| process_type TYPE c LENGTH 50, | ||
Markus1812 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "! <p class="shorttext">Process Version</p> | ||
| "! DRC Process Version | ||
| "! $required | ||
| process_version TYPE c LENGTH 20, | ||
| "! <p class="shorttext">Process Subtype</p> | ||
| "! DRC Process Subtype | ||
| "! $required | ||
| process_subtype TYPE c LENGTH 50, | ||
| "! <p class="shorttext">Action</p> | ||
| "! DRC Process Action | ||
| "! $required | ||
| drc_action TYPE c LENGTH 30, | ||
| "! <p class="shorttext">Response Interface</p> | ||
| "! eDoc Response Interface | ||
| "! $required | ||
| resp_interface_id TYPE c LENGTH 30, | ||
GuilhermeSaraiva96 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "! <p class="shorttext">Response Interface Version</p> | ||
| "! Response Interface Version | ||
| "! $required | ||
| resp_int_version TYPE c LENGTH 4, | ||
GuilhermeSaraiva96 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| END OF ty_edoc_int_drc_attr. | ||
| "! <p class="shorttext">Interface Versions</p> | ||
| "! eDocument Interface Versions | ||
| TYPES ty_edoc_int_drc_attributes TYPE SORTED TABLE OF ty_edoc_int_drc_attr WITH UNIQUE KEY process_type. | ||
GuilhermeSaraiva96 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| TYPES: | ||
| "! <p class="shorttext">General Information</p> | ||
| "! eDocument Interface | ||
| BEGIN OF ty_edoc_interface, | ||
| "! <p class="shorttext">eDocument Interface</p> | ||
| "! eDocument Interface | ||
| "! $required | ||
| edocument_interface_id TYPE c LENGTH 30, | ||
| "! <p class="shorttext">eDocument Interface Description</p> | ||
| "! Interface Description. | ||
| "! $required | ||
| interface_description TYPE c LENGTH 100, | ||
i506210 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| "! <p class="shorttext">eDocument Interface Direction</p> | ||
| "! Interface Direction. | ||
| "! $required | ||
| interface_direction TYPE ty_int_direction, | ||
|
|
||
| "! <p class="shorttext">Interface Version</p> | ||
| "! Interface Version | ||
| "! $required | ||
| edocument_interface_version TYPE ty_edoc_interface_versions, | ||
| "! <p class="shorttext">Attribute Determination for Communication with Cloud Edition</p> | ||
| "! DRC Integration Attribute Determination | ||
| "! $required | ||
| edoc_spec_additional_table TYPE ty_edoc_int_drc_attributes, | ||
| END OF ty_edoc_interface. | ||
| TYPES: | ||
| "! <p class="shorttext">eDocument Interface</p> | ||
| "! eDocument Interface | ||
| BEGIN OF ty_main, | ||
| "! <p class="shorttext">Format Version</p> | ||
| "! Format version | ||
| "! $required | ||
| format_version TYPE zif_aff_types_v1=>ty_format_version, | ||
| "! <p class="shorttext">Header</p> | ||
| "! Header | ||
| "! $required | ||
| header TYPE zif_aff_types_v1=>ty_header_60, | ||
| "! <p class="shorttext">eDocument Interface</p> | ||
| "! eDocument Interface | ||
| "! $required | ||
| general_information TYPE ty_edoc_interface, | ||
|
|
||
| END OF ty_main. | ||
|
|
||
| CONSTANTS: | ||
GuilhermeSaraiva96 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "! <p class="shorttext">Interface Direction</p> | ||
| "! Interface Direction | ||
| BEGIN OF co_edoc_int_direction, | ||
| "! <p class="shorttext">Outbound</p> | ||
| "! Outbound | ||
| outbound TYPE ty_int_direction VALUE 'O', | ||
| "! <p class="shorttext">Inbound</p> | ||
| "! Inbound | ||
| inbound TYPE ty_int_direction VALUE 'I', | ||
| END OF co_edoc_int_direction. | ||
| ENDINTERFACE. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "formatVersion": "1", | ||
| "header": { | ||
| "description": "Create eDocument Types", | ||
i506210 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "originalLanguage": "en" | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example is missing. The example (and its example data) would be really helpful for our reviews. In the end it is needed anyhow.
If this won't be feasible we should create at least an issue in this repository for adding the example later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now I haven't worked on preparing example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, before we merge, we should create at least an issue for this in this repository. Pleas keep this comment as unresolved...