der: improved internal ref types #1921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
der/improved-internal-ref-types
branch
2 times, most recently
from
e1d43cb to
8976040
Compare
Changes `BytesRef` and `StringRef` from types with an explicit lifetime which act as newtypes for inner `&'a [u8]` and `&'a str` types to being newtypes for `[u8]` and `str`. This requires a very small amount of `unsafe` casting, but makes it possible to implement reference conversions entirely in terms of standard traits like `AsRef`, `Borrow`, `Deref`, and `ToOwned` as opposed to using our custom `RefToOwned` and OwnedToRef` traits. It makes it possible to use e.g. `Cow` as well. This is the first step towards moving the entire crate to this pattern and eliminating the `OwnedToRef` and `RefToOwned` raits, replacing them instead with the standard `AsRef` and `ToOwned` traits.
tarcieri
force-pushed
the
der/improved-internal-ref-types
branch
from
8976040 to
7284d50
Compare
|
cc @dishmaker I'm going to try to do this conversion incrementally a bit at a time. That also makes it potentially possible to split up the work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
BytesRefandStringReffrom types with an explicit lifetime which act as newtypes for inner&'a [u8]and&'a strtypes to being newtypes for[u8]andstr.This requires a very small amount of
unsafecasting, but makes it possible to implement reference conversions entirely in terms of standard traits likeAsRef,Borrow,Deref, andToOwnedas opposed to using our customRefToOwnedand OwnedToReftraits. It makes it possible to use e.g.Cow` as well.This is the first step towards moving the entire crate to this pattern and eliminating the
OwnedToRefandRefToOwnedraits, replacing them instead with the standardAsRefandToOwnedtraits.