chore(deps): batch dependency updates and MSTest v4 migration#144
Merged
RoySalisbury merged 2 commits intomainfrom Mar 27, 2026
Merged
chore(deps): batch dependency updates and MSTest v4 migration#144RoySalisbury merged 2 commits intomainfrom
RoySalisbury merged 2 commits intomainfrom
Conversation
Dependency updates (addresses Dependabot PRs #130-#134, #136-#139): - OpenTelemetry.Api: 1.9.0 → 1.15.0 - OpenTelemetry.Extensions.Hosting: 1.9.0 → 1.15.0 - OpenTelemetry.Exporter.OpenTelemetryProtocol: 1.9.0 → 1.15.0 - StackExchange.Redis: 2.6.122 → 2.11.8 - Serilog: 3.1.1 → 4.3.1 - MSTest.TestAdapter: 3.7.0 → 4.1.0 - MSTest.TestFramework: 3.7.0 → 4.1.0 - Npgsql: 9.0.3 → 10.0.1 (test-only) - Swashbuckle.AspNetCore: 10.1.2 → 10.1.4 (samples) - dorny/test-reporter: v2 → v3 (CI workflow) MSTest v4 migration: - Replace Assert.ThrowsException with Assert.ThrowsExactly - Replace Assert.ThrowsExceptionAsync with Assert.ThrowsExactlyAsync - Convert [ExpectedException] attribute to Assert.ThrowsExactly pattern - Replace [DataTestMethod] with [TestMethod] (unified in v4) - Suppress MSTEST0032 (trivially-true assertions) in test props OTel 1.15.0 compatibility: - Suppress CS0618 for OtlpExportProtocol.Grpc on netstandard2.0 Package version bumps: - HVO.Enterprise.Telemetry: 1.0.1 → 1.0.2 - HVO.Enterprise.Telemetry.OpenTelemetry: 1.1.0 → 1.1.1 - HVO.Enterprise.Telemetry.Data.Redis: 1.0.1 → 1.0.2 - HVO.Enterprise.Telemetry.Serilog: 1.0.1 → 1.1.0 Not merged (closing separately): - RabbitMQ.Client 6→7 (#135): Major API overhaul requires dedicated story Build: 0 warnings, 0 errors Tests: 2158 passed, 9 skipped, 0 failed
This was referenced Mar 26, 2026
This was referenced Mar 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR batches multiple dependency upgrades across the telemetry libraries and test projects, including migrating the test suite to MSTest v4, updating OpenTelemetry to 1.15.0, bumping Serilog to 4.x, and updating CI test reporting.
Changes:
- Upgrade OpenTelemetry packages to 1.15.0 and adjust OTLP exporter configuration for netstandard2.0 warning behavior.
- Upgrade Serilog to 4.3.1 and bump related package/test references.
- Migrate tests to MSTest v4.1.0 (replace
[ExpectedException],ThrowsException*, and[DataTestMethod]patterns) and update CIdorny/test-reporterto v3.
Reviewed changes
Copilot reviewed 129 out of 129 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/HVO.Enterprise.Telemetry.Wcf.Tests/WcfServerIntegrationTests.cs | Migrates exception assertion to MSTest v4 ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Wcf.Tests/WcfDispatchInspectorProxyTests.cs | Migrates exception assertion to MSTest v4 ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Wcf.Tests/W3CTraceContextPropagatorTests.cs | Migrates exception assertion to MSTest v4 ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Wcf.Tests/TelemetryClientMessageInspectorTests.cs | Migrates exception assertion to MSTest v4 ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Wcf.Tests/TelemetryClientEndpointBehaviorTests.cs | Migrates exception assertion to MSTest v4 ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Wcf.Tests/SoapHeaderAccessorTests.cs | Migrates exception assertion to MSTest v4 ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Wcf.Tests/ServiceCollectionExtensionsTests.cs | Migrates exception assertion to MSTest v4 ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Wcf.Tests/HVO.Enterprise.Telemetry.Wcf.Tests.csproj | Bumps MSTest packages to v4.1.0. |
| tests/HVO.Enterprise.Telemetry.Wcf.Tests/ClientBaseExtensionsTests.cs | Migrates exception assertion to MSTest v4 ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/TelemetryTests.cs | Migrates exception assertion to MSTest v4 ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Sampling/SamplingActivitySourceExtensionsTests.cs | Migrates exception assertion to MSTest v4 ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Proxies/TelemetryProxyFactoryTests.cs | Migrates exception assertion to MSTest v4 ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Proxies/TelemetryInstrumentationExtensionsTests.cs | Migrates exception assertion to MSTest v4 ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Proxies/TelemetryDispatchProxyTests.cs | Migrates exception assertion to MSTest v4 ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Proxies/AsyncProxyTests.cs | Migrates async exception assertions to ThrowsExactlyAsync. |
| tests/HVO.Enterprise.Telemetry.Tests/OperationScopes/OperationScopeFactoryComprehensiveTests.cs | Migrates exception assertion to MSTest v4 ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/OperationScopes/OperationScopeExtensionsTests.cs | Migrates exception assertions to ThrowsExactly/ThrowsExactlyAsync. |
| tests/HVO.Enterprise.Telemetry.Tests/OperationScopes/OperationScopeExtensionsComprehensiveTests.cs | Migrates exception assertions to ThrowsExactly/ThrowsExactlyAsync. |
| tests/HVO.Enterprise.Telemetry.Tests/OperationScopes/OperationScopeComprehensiveTests.cs | Migrates exception assertion to MSTest v4 ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Metrics/TelemetryBackgroundWorkerTests.cs | Migrates exception assertions to ThrowsExactly/ThrowsExactlyAsync. |
| tests/HVO.Enterprise.Telemetry.Tests/Metrics/OperationScopeMetricsTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Metrics/MetricRecorderTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Metrics/MetricNameValidatorTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Metrics/MeterApiRecorderComprehensiveTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Logging/TelemetryLoggerTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Logging/TelemetryLoggerExtensionsTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Logging/TelemetryEnrichedLoggerTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Logging/TelemetryEnrichedLoggerProviderTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Logging/TelemetryEnrichedLoggerFactoryTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Logging/LogEnrichmentScopeTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Logging/BuiltInEnricherTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Lifecycle/TelemetryLifetimeManagerTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Lifecycle/TelemetryLifetimeManagerComprehensiveTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Lifecycle/TelemetryLifetimeHostedServiceTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Lifecycle/TelemetryLifetimeExtensionsTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Lifecycle/TelemetryBackgroundWorkerComprehensiveTests.cs | Migrates exception assertions to ThrowsExactly/ThrowsExactlyAsync. |
| tests/HVO.Enterprise.Telemetry.Tests/Initialization/TelemetryServiceTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Initialization/TelemetryOptionsExtendedTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Initialization/TelemetryBuilderTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Initialization/StaticTelemetryTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Initialization/DependencyInjectionTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Http/TelemetryHttpMessageHandlerTests.cs | Migrates async exception assertions + switches parameterized tests to [TestMethod] pattern. |
| tests/HVO.Enterprise.Telemetry.Tests/Http/HttpInstrumentationOptionsTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Http/ActivityExtensionsTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/HealthChecks/TelemetryHealthCheckTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/HealthChecks/TelemetryHealthCheckOptionsTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/HealthChecks/TelemetryHealthCheckExtensionsTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/HealthChecks/RollingWindowTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/HVO.Enterprise.Telemetry.Tests.csproj | Bumps MSTest packages to v4.1.0. |
| tests/HVO.Enterprise.Telemetry.Tests/Exceptions/TelemetryExceptionExtensionsTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Exceptions/FirstChanceExceptionMonitorTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Exceptions/ExceptionAggregatorComprehensiveTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Correlation/CorrelationContextTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Context/ContextEnricherComprehensiveTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Configuration/TelemetryOptionsTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Configuration/OperationConfigurationTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Configuration/FluentConfiguratorTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Configuration/ConfiguratorEdgeCaseTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Configuration/ConfigurationHttpEndpointTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Configuration/ConfigurationFileProviderTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Configuration/ConfigurationEntryTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Capture/SensitiveDataDetectionTests.cs | Migrates to [TestMethod] pattern + ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Capture/CaptureLevelTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/Capture/CaptureExtensionTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Tests/BackgroundJobs/BackgroundJobExtensionsTests.cs | Migrates exception assertions to ThrowsExactly/ThrowsExactlyAsync. |
| tests/HVO.Enterprise.Telemetry.Tests/BackgroundJobs/BackgroundJobContextTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Serilog.Tests/LoggerEnrichmentConfigurationExtensionsTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Serilog.Tests/HVO.Enterprise.Telemetry.Serilog.Tests.csproj | Bumps MSTest to v4.1.0 and Serilog to 4.3.1 in tests. |
| tests/HVO.Enterprise.Telemetry.Serilog.Tests/CorrelationEnricherTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Serilog.Tests/ActivityEnricherTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.OpenTelemetry.Tests/TelemetryBuilderExtensionsTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.OpenTelemetry.Tests/ServiceCollectionExtensionsTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.OpenTelemetry.Tests/HvoActivitySourceRegistrarTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.OpenTelemetry.Tests/HVO.Enterprise.Telemetry.OpenTelemetry.Tests.csproj | Bumps MSTest to v4.1.0. |
| tests/HVO.Enterprise.Telemetry.IIS.Tests/ServiceCollectionExtensionsTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.IIS.Tests/IisShutdownHandlerTests.cs | Migrates async exception assertions to ThrowsExactlyAsync. |
| tests/HVO.Enterprise.Telemetry.IIS.Tests/IisLifecycleManagerTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.IIS.Tests/IisExtensionOptionsTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.IIS.Tests/HVO.Enterprise.Telemetry.IIS.Tests.csproj | Bumps MSTest to v4.1.0. |
| tests/HVO.Enterprise.Telemetry.Grpc.Tests/TelemetryServerInterceptorTests.cs | Migrates exception assertions to ThrowsExactly/ThrowsExactlyAsync. |
| tests/HVO.Enterprise.Telemetry.Grpc.Tests/TelemetryClientInterceptorTests.cs | Migrates exception assertions to ThrowsExactly/ThrowsExactlyAsync. |
| tests/HVO.Enterprise.Telemetry.Grpc.Tests/TelemetryBuilderExtensionsTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Grpc.Tests/ServiceCollectionExtensionsTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Grpc.Tests/HVO.Enterprise.Telemetry.Grpc.Tests.csproj | Bumps MSTest to v4.1.0. |
| tests/HVO.Enterprise.Telemetry.Datadog.Tests/TelemetryBuilderExtensionsTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Datadog.Tests/ServiceCollectionExtensionsTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Datadog.Tests/HVO.Enterprise.Telemetry.Datadog.Tests.csproj | Bumps MSTest to v4.1.0. |
| tests/HVO.Enterprise.Telemetry.Datadog.Tests/DatadogTraceExporterTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Datadog.Tests/DatadogMetricsExporterTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Data.Tests/SqlOperationDetectorTests.cs | Switches to [TestMethod] pattern for data rows. |
| tests/HVO.Enterprise.Telemetry.Data.Tests/ServiceCollectionExtensionsTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Data.Tests/ParameterSanitizerTests.cs | Switches to [TestMethod] pattern for data rows. |
| tests/HVO.Enterprise.Telemetry.Data.Tests/HVO.Enterprise.Telemetry.Data.Tests.csproj | Bumps MSTest to v4.1.0. |
| tests/HVO.Enterprise.Telemetry.Data.Redis.Tests/ServiceCollectionExtensionsTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Data.Redis.Tests/RedisTelemetryProfilerTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Data.Redis.Tests/HVO.Enterprise.Telemetry.Data.Redis.Tests.csproj | Bumps MSTest to v4.1.0 and StackExchange.Redis to 2.11.8. |
| tests/HVO.Enterprise.Telemetry.Data.RabbitMQ.Tests/TelemetryModelTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Data.RabbitMQ.Tests/ServiceCollectionExtensionsTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Data.RabbitMQ.Tests/HVO.Enterprise.Telemetry.Data.RabbitMQ.Tests.csproj | Bumps MSTest to v4.1.0. |
| tests/HVO.Enterprise.Telemetry.Data.EfCore.Tests/TelemetryDbCommandInterceptorTests.cs | Migrates exception assertions + [TestMethod] data rows. |
| tests/HVO.Enterprise.Telemetry.Data.EfCore.Tests/ServiceCollectionExtensionsTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Data.EfCore.Tests/HVO.Enterprise.Telemetry.Data.EfCore.Tests.csproj | Bumps MSTest to v4.1.0. |
| tests/HVO.Enterprise.Telemetry.Data.AdoNet.Tests/ServiceCollectionExtensionsTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Data.AdoNet.Tests/InstrumentedDbConnectionTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.Data.AdoNet.Tests/InstrumentedDbCommandTests.cs | Switches to [TestMethod] data rows + migrates exception assertions. |
| tests/HVO.Enterprise.Telemetry.Data.AdoNet.Tests/HVO.Enterprise.Telemetry.Data.AdoNet.Tests.csproj | Bumps MSTest to v4.1.0 and Npgsql to 10.0.1. |
| tests/HVO.Enterprise.Telemetry.Data.AdoNet.Tests/DbConnectionExtensionsTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.AppInsights.Tests/TelemetryConfigurationExtensionsTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.AppInsights.Tests/TelemetryBuilderExtensionsTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.AppInsights.Tests/ServiceCollectionExtensionsTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.AppInsights.Tests/HVO.Enterprise.Telemetry.AppInsights.Tests.csproj | Bumps MSTest to v4.1.0. |
| tests/HVO.Enterprise.Telemetry.AppInsights.Tests/CorrelationTelemetryInitializerTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.AppInsights.Tests/ApplicationInsightsBridgeTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Telemetry.AppInsights.Tests/ActivityTelemetryInitializerTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Enterprise.Samples.Net8.Tests/HVO.Enterprise.Samples.Net8.Tests.csproj | Bumps MSTest to v4.1.0 (net8 sample tests). |
| tests/HVO.Common.Tests/Utilities/GuardTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Common.Tests/Results/ResultTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Common.Tests/OneOf/OneOfTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Common.Tests/OneOf/NamedOneOfAttributeTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/HVO.Common.Tests/HVO.Common.Tests.csproj | Bumps MSTest to v4.1.0. |
| tests/HVO.Common.Tests/Extensions/ExtensionTests.cs | Migrates exception assertions to ThrowsExactly. |
| tests/Directory.Build.props | Suppresses MSTEST0032 across test projects. |
| src/HVO.Enterprise.Telemetry/HVO.Enterprise.Telemetry.csproj | Bumps package version and OpenTelemetry.Api dependency. |
| src/HVO.Enterprise.Telemetry.Serilog/HVO.Enterprise.Telemetry.Serilog.csproj | Bumps package version and Serilog dependency to 4.x. |
| src/HVO.Enterprise.Telemetry.OpenTelemetry/ServiceCollectionExtensions.cs | Suppresses CS0618 for OTLP gRPC protocol enum on netstandard2.0. |
| src/HVO.Enterprise.Telemetry.OpenTelemetry/HVO.Enterprise.Telemetry.OpenTelemetry.csproj | Bumps package version + OpenTelemetry SDK dependencies to 1.15.0. |
| src/HVO.Enterprise.Telemetry.Data.Redis/HVO.Enterprise.Telemetry.Data.Redis.csproj | Bumps package version + StackExchange.Redis dependency. |
| samples/HVO.Enterprise.Samples.Net8/HVO.Enterprise.Samples.Net8.csproj | Bumps Swashbuckle.AspNetCore. |
| .github/workflows/ci.yml | Updates dorny/test-reporter action from v2 to v3. |
Comment on lines
+5
to
+9
| <PackageId>HVO.Enterprise.Telemetry.Serilog</PackageId> | ||
| <Version>1.0.1</Version> | ||
| <Version>1.1.0</Version> | ||
| <Description>Serilog enrichers for HVO.Enterprise.Telemetry providing automatic Activity tracing and correlation context enrichment in Serilog log events.</Description> | ||
| <PackageTags>telemetry;serilog;enricher;logging;correlation;tracing</PackageTags> | ||
| <PackageReleaseNotes></PackageReleaseNotes> | ||
| <PackageReleaseNotes>v1.1.0: Update Serilog dependency from 3.1.1 to 4.3.1. BREAKING: Consumers must use Serilog 4.x or later.</PackageReleaseNotes> |
There was a problem hiding this comment.
HVO.Enterprise.Telemetry.Serilog is taking a breaking dependency change (Serilog 3.x -> 4.x), but the package version is only being bumped from 1.0.1 to 1.1.0. If this library follows SemVer, this should be a major version bump (e.g., 2.0.0) to avoid surprising downstream consumers that get the update via floating versions.
Also consider adding a brief note for .NET Framework consumers about potential binding redirect impacts with Serilog 4.x (assembly version now matches package version).
Comment on lines
+256
to
+260
| #pragma warning disable CS0618 // OTel 1.15 warns about gRPC on netstandard2.0; users opt in via config | ||
| exporterOptions.Protocol = options.Transport == OtlpTransport.Grpc | ||
| ? OtlpExportProtocol.Grpc | ||
| : OtlpExportProtocol.HttpProtobuf; | ||
| #pragma warning restore CS0618 |
There was a problem hiding this comment.
The CS0618 suppression for OtlpExportProtocol.Grpc makes sense for an explicit opt-in, but OtlpExportOptions.Transport currently defaults to Grpc (see OtlpExportOptions.Transport default). That means the deprecated gRPC protocol is still the default behavior for netstandard2.0 consumers, and the pragma will hide the warning even when users haven’t explicitly chosen gRPC.
Consider either (a) changing the default transport/endpoint for netstandard2.0 to HTTP/Protobuf, or (b) updating option validation/docs so that gRPC is only used when explicitly configured (and guide users toward HTTP/Protobuf by default).
Suggested change
| #pragma warning disable CS0618 // OTel 1.15 warns about gRPC on netstandard2.0; users opt in via config | |
| exporterOptions.Protocol = options.Transport == OtlpTransport.Grpc | |
| ? OtlpExportProtocol.Grpc | |
| : OtlpExportProtocol.HttpProtobuf; | |
| #pragma warning restore CS0618 | |
| exporterOptions.Protocol = OtlpExportProtocol.HttpProtobuf; |
…p Serilog to v2.0.0 - Change default OTLP transport from gRPC to HTTP/Protobuf (port 4318) gRPC is deprecated on .NET Standard 2.0 targets in OTel SDK 1.15+ - Add _transportExplicitlySet flag so auto-detection only fires when Transport property was not explicitly configured by the consumer - Bump HVO.Enterprise.Telemetry.Serilog to v2.0.0 (breaking: Serilog 3→4) with binding redirect guidance in release notes - Update OtlpTransport enum XML docs (HttpProtobuf is now the default) - Update all affected unit tests for new default values
Owner
Author
|
Addressed both review comments in commit a27a717:
All 2,158 tests pass (9 skipped), 0 warnings, 0 errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batch dependency update addressing 9 of 10 open Dependabot PRs. Includes MSTest v4 migration, OpenTelemetry SDK update, Serilog major version bump, and several other dependency updates.
Closes #130, closes #131, closes #132, closes #133, closes #134, closes #136, closes #137, closes #138, closes #139
Dependency Updates
Package Version Bumps
MSTest v4 Migration (129 files changed)
Assert.ThrowsException<T>toAssert.ThrowsExactly<T>(96 call sites)Assert.ThrowsExceptionAsync<T>toAssert.ThrowsExactlyAsync<T>(6 call sites)[ExpectedException(typeof(X))]toAssert.ThrowsExactly<X>(() => ...)(87 test methods)[DataTestMethod]to[TestMethod](unified in v4)OTel 1.15.0 Compatibility
OtlpExportProtocol.Grpcis now[Obsolete]for netstandard2.0 targets (recommends HTTP/Protobuf)Not Merged
Quality Gates