Fix settings dirty check

[mrubens]

This fixes an issue where every time you open provider settings with an OpenRouter model selected you need to "discard changes" before saving, even though you didn't change anything.

---

Important

Fixes issue in SettingsView.tsx where initial sync of model ID was incorrectly marked as a change, requiring unnecessary discard action.

• Behavior:
  • Fixes issue in SettingsView.tsx where opening provider settings with an OpenRouter model required discarding changes before saving, even if no changes were made.
  • Prevents marking initial sync from undefined to defined value as a change in setApiConfigurationField.
• Components:
  • Updates useEffect in ApiOptions.tsx to include apiConfiguration.apiModelId in dependency array to prevent unnecessary updates.

^{This description was created by for 405c7b5. You can customize this summary. It will automatically update as commits are pushed.}

[delve-auditor]

✅ No security or compliance issues detected. Reviewed everything up to 405c7b5.

Security Overview

• 🔎 Scanned files: 2 changed file(s)

Detected Code Changes

Change Type	Relevant files
Bug Fix	► ApiOptions.tsx     Fix model selection state update condition ► SettingsView.tsx     Improve settings dirty check logic

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

[daniel-lxs]

LGTM.

For future consideration: I think we should look into the useEffect in webview-ui/src/components/settings/ApiOptions.tsx (lines 169-173) that syncs all providers' models to apiModelId. Many providers use their own fields:

• OpenRouter → openRouterModelId
• Glama → glamaModelId
• OpenAI → openAiModelId
• etc.

This might be causing unnecessary updates when these providers are selected. It could be worth exploring a more targeted approach that checks the provider type and only syncs for those that actually use apiModelId (anthropic, gemini, deepseek, etc.).