Skip to content

feat: Add provider-level todo list toggle with advanced settings section #5624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/types/src/provider-settings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ export type ProviderSettingsEntry = z.infer<typeof providerSettingsEntrySchema>
const baseProviderSettingsSchema = z.object({
includeMaxTokens: z.boolean().optional(),
diffEnabled: z.boolean().optional(),
enableTodoList: z.boolean().optional(),
fuzzyMatchThreshold: z.number().optional(),
modelTemperature: z.number().nullish(),
rateLimitSeconds: z.number().optional(),
Expand Down
25 changes: 25 additions & 0 deletions src/core/config/ProviderSettingsManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ export const providerProfilesSchema = z.object({
.object({
rateLimitSecondsMigrated: z.boolean().optional(),
diffSettingsMigrated: z.boolean().optional(),
todoListSettingsMigrated: z.boolean().optional(),
openAiHeadersMigrated: z.boolean().optional(),
})
.optional(),
Expand All @@ -47,6 +48,7 @@ export class ProviderSettingsManager {
migrations: {
rateLimitSecondsMigrated: true, // Mark as migrated on fresh installs
diffSettingsMigrated: true, // Mark as migrated on fresh installs
todoListSettingsMigrated: true, // Mark as migrated on fresh installs
openAiHeadersMigrated: true, // Mark as migrated on fresh installs
},
}
Expand Down Expand Up @@ -112,6 +114,7 @@ export class ProviderSettingsManager {
providerProfiles.migrations = {
rateLimitSecondsMigrated: false,
diffSettingsMigrated: false,
todoListSettingsMigrated: false,
openAiHeadersMigrated: false,
} // Initialize with default values
isDirty = true
Expand All @@ -129,6 +132,12 @@ export class ProviderSettingsManager {
isDirty = true
}

if (!providerProfiles.migrations.todoListSettingsMigrated) {
await this.migrateTodoListSettings(providerProfiles)
providerProfiles.migrations.todoListSettingsMigrated = true
isDirty = true
}

if (!providerProfiles.migrations.openAiHeadersMigrated) {
await this.migrateOpenAiHeaders(providerProfiles)
providerProfiles.migrations.openAiHeadersMigrated = true
Expand Down Expand Up @@ -204,6 +213,22 @@ export class ProviderSettingsManager {
}
}

private async migrateTodoListSettings(providerProfiles: ProviderProfiles) {
try {
// No backfill required - this is a new provider-level setting
// Default to true (enabled) for all existing profiles
const defaultTodoListEnabled = true

for (const [_name, apiConfig] of Object.entries(providerProfiles.apiConfigs)) {
if (apiConfig.enableTodoList === undefined) {
apiConfig.enableTodoList = defaultTodoListEnabled
}
}
} catch (error) {
console.error(`[MigrateTodoListSettings] Failed to migrate todo list settings:`, error)
}
}

private async migrateOpenAiHeaders(providerProfiles: ProviderProfiles) {
try {
for (const [_name, apiConfig] of Object.entries(providerProfiles.apiConfigs)) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ describe("ProviderSettingsManager", () => {
rateLimitSecondsMigrated: true,
diffSettingsMigrated: true,
openAiHeadersMigrated: true,
todoListSettingsMigrated: true,
},
}),
)
Expand Down
6 changes: 4 additions & 2 deletions src/core/environment/getEnvironmentDetails.ts
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,8 @@ export async function getEnvironmentDetails(cline: Task, includeFileDetails: boo
}
}

const reminderSection = formatReminderSection(cline.todoList)
return `<environment_details>\n${details.trim()}\n${reminderSection}\n</environment_details>`
// Only include reminder section if todo list tool is enabled
const enableTodoList = state?.apiConfiguration?.enableTodoList ?? true
const reminderSection = enableTodoList ? formatReminderSection(cline.todoList) : ""
return `<environment_details>\n${details.trim()}${reminderSection ? `\n${reminderSection}` : ""}\n</environment_details>`
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading