Message edit/delete overhaul

[liwilliam2021]

Four big changes (note this feature is still disabled until checkpoints are overhauled)

1. Made the edit interface a variation of the Chat Area
2. Use our own modal instead of native vscode modal for delete/edit warnings
3. Removed the option to "delete just this message" and replaced with a warning
   4. Added an option to stop showing edit/delete warnings

Partially addresses #4703

---

Important

Overhauls message edit/delete functionality with custom modals, removes individual delete option, and updates edit interface to resemble chat area.

• Behavior:
  • Overhauls message edit/delete functionality with a custom modal for confirmations in webviewMessageHandler.ts.
  • Removes "delete just this message" option, replacing it with a warning.
  • Adds option to stop showing edit/delete warnings.
• UI Changes:
  • Updates edit interface to resemble chat area in App.tsx.
  • Introduces DeleteMessageDialog and EditMessageDialog components in App.tsx.
• Testing:
  • Updates tests in ClineProvider.spec.ts to reflect new delete/edit behavior.
  • Adds tests for edit mode integration in ChatTextArea.spec.tsx and EditModeControls.spec.tsx.

^{This description was created by for cf53be7. You can customize this summary. It will automatically update as commits are pushed.}

[delve-auditor]

✅ No security or compliance issues detected. Reviewed everything up to 7031254.

Security Overview

• 🔎 Scanned files: 69 changed file(s)

Detected Code Changes

The diff is too large to display a summary of code changes.

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

[daniel-lxs]

Hey @liwilliam2021, I gave the implementation a try and noticed a couple of issues. It looks like editing a message and attaching a new image doesn’t work as expected right now.

Also, I think we could simplify the UI a bit by removing the codebase indexing status indicator, and adjust the styles so the edit message text area feels more integrated. Right now it looks a bit like a box inside a box.

Let me know if anything's unclear or if you’d like to talk through any of this.

[liwilliam2021]

Hey @liwilliam2021, I gave the implementation a try and noticed a couple of issues. It looks like editing a message and attaching a new image doesn’t work as expected right now.

Also, I think we could simplify the UI a bit by removing the codebase indexing status indicator, and adjust the styles so the edit message text area feels more integrated. Right now it looks a bit like a box inside a box.

Let me know if anything's unclear or if you’d like to talk through any of this.

hmmm weird-- they seemed to work locally on my end? thanks for the feedback will check it out!

[liwilliam2021]

Thanks @daniel-lxs -- those are great catches!

I also removed the skip warning dialog option bc it will be replaced in the next PR anyways.

[daniel-lxs]

Hey Will, thank you for addressing the suggestions.

I noticed that the model doesn't seem to be aware of the images being sent:

Maybe I'm doing something wrong here?

Also, I think the padding around the text area could be a bit smaller:

[liwilliam2021]

Hey Will, thank you for addressing the suggestions.

I noticed that the model doesn't seem to be aware of the images being sent:

Maybe I'm doing something wrong here?

Also, I think the padding around the text area could be a bit smaller:

I just addressed the padding issues :)

hmmm-- the image issue doesn't seem to appear on my end, check out this loom

https://www.loom.com/share/156cd936f3bf432887408f53e717789c

[daniel-lxs]

I think this is working correctly. I'll leave a few minor suggestions, but I think it's close to being done.