BUG: Wrong Phi Initialization For nose_to_tail Rockets
#809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phmbressan
approved these changes
Apr 21, 2025
github-project-automation
bot
moved this from Backlog
to Next Version
in LibDev Roadmap
…m/RocketPy into bug/inverted-rocket
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #809 +/- ##
===========================================
+ Coverage 79.11% 79.79% +0.67%
===========================================
Files 96 97 +1
Lines 11575 11899 +324
===========================================
+ Hits 9158 9495 +337
+ Misses 2417 2404 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior
Simulation with
nose_to_tailrockets andtail_to_noserockets were not identical given correct inputs. If you did this with calisto, this difference was really small, but for rockets with more complex parts (individual fins, generic surfaces...) this became more apparent.New behavior
The problem came from the initialization of the initial spin angle. The initialization was corrected and a test was created to assert equivalence of both coordinate systems.
Breaking change