Skip to content

Conversation

OtavioStasiak
Copy link
Contributor

@OtavioStasiak OtavioStasiak commented Jan 24, 2025

Proposed changes

Issue(s)

https://rocketchat.atlassian.net/browse/MA-114

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@OtavioStasiak OtavioStasiak changed the title chore: added accessibilityRole on listHeader chore(a11y): Titles from menus marked as headings Jan 24, 2025
@OtavioStasiak OtavioStasiak marked this pull request as ready for review January 24, 2025 22:40
@diegolmello diegolmello changed the title chore(a11y): Titles from menus marked as headings feat(a11y): Titles from menus marked as headings Feb 25, 2025
@OtavioStasiak OtavioStasiak merged commit 8796db6 into develop Feb 26, 2025
3 of 8 checks passed
@OtavioStasiak OtavioStasiak deleted the chore-titles-menu-as-headings branch February 26, 2025 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants