Skip to content

improve slider #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2024
Merged

improve slider #355

merged 1 commit into from
Dec 12, 2024

Conversation

yibeichan
Copy link
Contributor

here we did

  1. prioritize minValue and maxValue over choices
  2. support both continuous and discrete options. to get discrete options, we need to remove minValue and maxValue but only keep choices
  3. when both minValue&maxValue and choices present, we use minValue&maxValue for the scale and choices for labeling.
  4. as long as choices is odd number, we present three labels (min, mid, max)

the following has minValue (0)&maxValue(100) and choices (5 in total), so the scale is continuous but the labels are three.
image

@yibeichan
Copy link
Contributor Author

@satra how about this one?

@satra
Copy link
Contributor

satra commented Dec 12, 2024 via email

@yibeichan yibeichan merged commit 771c460 into main Dec 12, 2024
2 checks passed
@yibeichan yibeichan deleted the fix-slider branch December 12, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants