Skip to content

[fix] update missing item in activity 4 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[fix] update missing item in activity 4 #16

wants to merge 2 commits into from

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Jun 4, 2021

Quick fix:

  • email item is already in activity 3
  • float item was not presented in activity 4

@Remi-Gau
Copy link
Contributor Author

Remi-Gau commented Jun 4, 2021

Side note that might be more appropriate on the reproschem-py repo: Shouldn't validation also ensure that the items listed in an activity actually "exist"?
Other wise most apps that implement the schema will just hang eternally.

@satra
Copy link
Contributor

satra commented Jun 4, 2021

Shouldn't validation also ensure that the items listed in an activity actually "exist"?

Good question. Validation checks the graph presently not content derived from a location. So it checks that the pointer acts as a uri not a url. Indeed would be good to test that the uri are also url. That should be an easy addition given the triples.

@Remi-Gau
Copy link
Contributor Author

Remi-Gau commented Jun 4, 2021

will open an issue on reproschema-py at least a reminder

@Remi-Gau
Copy link
Contributor Author

Remi-Gau commented Dec 2, 2021

Closing as this is now obsolete

@Remi-Gau Remi-Gau closed this Dec 2, 2021
@Remi-Gau Remi-Gau deleted the fix_activity-4 branch December 2, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants