Issue 140 - add SSL support #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fe2s
approved these changes
Apr 25, 2020
This was referenced Apr 27, 2020
Closed
gkorland
reviewed
May 17, 2020
| @@ -23,7 +24,8 @@ object ConnectionPool { | |||
| poolConfig.setMinEvictableIdleTimeMillis(60000) | |||
| poolConfig.setTimeBetweenEvictionRunsMillis(30000) | |||
| poolConfig.setNumTestsPerEvictionRun(-1) | |||
| new JedisPool(poolConfig, re.host, re.port, re.timeout, re.auth, re.dbNum) | |||
|
|
|||
| new JedisPool(poolConfig, re.host, re.port, re.timeout, re.auth, re.dbNum, re.ssl) | |||
There was a problem hiding this comment.
@xianwill using this JedisPool constructor might be too week.
The following properties should also be supported
final SSLSocketFactory sslSocketFactory, final SSLParameters sslParameters,
final HostnameVerifier hostnameVerifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finishes out a branch proposed a while ago by @alanroche in #144 to add TLS support.
For our purposes we needed the additional constructor parameters for
RedisEndpointmentioned by @yananielsen in the notes of that PR to get everything working which I have added in this branch. I've also added a line of documentation in doc/configuration.md mentioning the ssl config option.