Skip to content

Fix: Introduced InternalExecutionTime() and removed RunTime() #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

filipecosta90
Copy link
Contributor

@filipecosta90 filipecosta90 commented Jan 22, 2021

The following PR removes RunTime() and introduces InternalExecutionTime().
Apart from it, the PR also introduces further testing to avoid unnoticed breakage in the future

@filipecosta90 filipecosta90 added the bug Something isn't working label Jan 22, 2021
@filipecosta90 filipecosta90 force-pushed the resultset.internalExecutionTime branch from f4e976d to 2fde04d Compare January 22, 2021 14:25
@filipecosta90 filipecosta90 changed the title Fix: Introduced InternalExecutionTime() and deprecated RunTime() Fix: Introduced InternalExecutionTime() and removed RunTime() Jan 22, 2021
@filipecosta90 filipecosta90 force-pushed the resultset.internalExecutionTime branch from 03b1446 to 2c9a965 Compare January 22, 2021 14:53
@swilly22 swilly22 merged commit aa0feaa into master Jan 22, 2021
@swilly22 swilly22 deleted the resultset.internalExecutionTime branch January 22, 2021 15:05
@filipecosta90 filipecosta90 linked an issue Jan 27, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RunTime() reported time of QueryResult is always zero for small internal execution time Server's run time should return as float64 rather than int
2 participants