Skip to content

Conversation

gkorland
Copy link
Contributor

No description provided.

@gkorland gkorland requested review from sazzad16 and DvirDukhan July 20, 2021 17:26
@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #128 (50e298e) into master (5792322) will increase coverage by 0.43%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #128      +/-   ##
============================================
+ Coverage     73.14%   73.58%   +0.43%     
  Complexity      206      206              
============================================
  Files            23       23              
  Lines           674      670       -4     
  Branches         61       61              
============================================
  Hits            493      493              
+ Misses          157      153       -4     
  Partials         24       24              
Impacted Files Coverage Δ
...islabs/redisgraph/impl/api/RedisGraphPipeline.java 45.23% <ø> (+3.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5792322...50e298e. Read the comment docs.

Copy link
Contributor

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gkorland Where is waitReplicas test?

@gkorland
Copy link
Contributor Author

@sazzad16 you're right but since we don't have any cluster/replication here I thought it will be useless, but I added a waitReplicas with 0 replicas just to make sure we still cover this code

@gkorland gkorland requested a review from sazzad16 July 21, 2021 05:47
@sazzad16
Copy link
Contributor

@gkorland yeah, I just realized, it's not Jedis test environment.

@gkorland gkorland requested a review from sazzad16 July 21, 2021 07:18
@gkorland gkorland merged commit 0237cd3 into master Jul 21, 2021
@gkorland gkorland deleted the waitReplicas branch July 21, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants