Skip to content

Make PageHeader component comply with Patternfly practices #2221

@Starle21

Description

@Starle21

PageHeader component natively defines too big a gap between children PageHeaderTitle and description components,
which is 24px (1.5rem).
Image

There is no easy way to change this from the outside.

// Using PageHeader without any Patternfly layouting components
<PageHeader>
      <PageHeaderTitle
        title={
          <>
            <span>{title}</span>
            <OpenSourceBadge repositoriesURL='https://github.com/content-services/content-sources-frontend' />
          </>
        }
      />
     // Native gap of 24px is applied, no way to change it
      <Content component='p' ouiaId={ouiaId}>
        {paragraph}
      </Content>
</PageHeader>

This big a gap does not comply with the Patternfly standards,
which sets the gap between a title and description to be 8px,
see the example on:
https://www.patternfly.org/components/page/react-demos/sticky-section-group-alternate-syntax/

Please update this component so:

  • it complies with Patternfly standard of 8px gap between a title and a description
  • there is a prop that changes gap from the outside

@MariSvirik(UX)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions