Allow VirtualTimeScheduler to run on any thread #2610
Allow VirtualTimeScheduler to run on any thread #2610freak4pc merged 2 commits intoReactiveX:mainfrom
Conversation
…ethods are all called on the same thread.
|
As far as I can tell, this is 100% backwards compatible and doesn't require any API change from users of the library. It may not solve every future use-case that Swift Testing might throw at it, but it solves the single most obvious one. I see no reason that this can't be accepted into the next minor release/update. |
|
What's the hold up in getting this merged? Would love to start being able to migrate our RxSwift tests to Swift Testing @nikolaykasyanov @danielt1263 |
|
We'll need someone with a meaningful RxSwift-based test suite to test this to make sure it doesn't break existing tests. |
|
@freak4pc I'll try it out and report back. |
|
@freak4pc I tried this PR on our relatively big test suite (around 1800 tests, most of which use |
That's awesome, thanks Nikolay! |
…as long as critical methods are all called on the same thread.
This is designed to fix issue #2609