Tidied up some code using optional map#2549
Merged
freak4pc merged 3 commits intoReactiveX:mainfrom Oct 3, 2024
Merged
Conversation
freak4pc
reviewed
Oct 21, 2023
Member
freak4pc
left a comment
There was a problem hiding this comment.
Nice fix! I added a clean-up suggestion.
| } else { | ||
| disposable = Disposables.create() | ||
| } | ||
| let disposable: Disposable = onDisposed.map({ Disposables.create(with: $0) }) ?? Disposables.create() |
| } else { | ||
| disposable = Disposables.create() | ||
| } | ||
| let disposable: Disposable = onDisposed.map({ Disposables.create(with: $0) }) ?? Disposables.create() |
…closure. Co-authored-by: Shai Mishali <freak4pc@gmail.com>
…er, instead of a closure.
Contributor
Author
|
Hey @freak4pc , I made the updates you suggested. Clever call with that! Let me know if there's anything else I can do. |
1198683 to
5949cbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply shortens/tidies up a few places of code, each of which were 3 lines, but could be written with just one using Optional's map function.
This feels like too small of change to mention in the changelog. If you disagree, let me know and I can make a mention.
I was also thinking of further condensing this code to the existing extension on
DisposablesinAnonymousDisposable.swift:That way, the three places I cleaned up wouldn't each be repeating the same logic. Let me know if that's something you'd want.