update rx dependency to 1.1.1 #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| byte[] buffer = new byte[size]; | ||
| try { | ||
| int count = is.read(buffer); | ||
| int count = this.is.read(buffer); |
There was a problem hiding this comment.
This is correct but I'd prefer to see state used here instead of this.is.
|
@davidmoten you are right, it's much better to use the state instead of ignoring it. I added the changes. |
|
👍 , thanks |
|
Thanks a lot for your PR! I have several applications which will use RxJava and RxJavaString to process HTTP streams on the fly, and I'd really like to be able to use the latest version of RxJava in the next release I have to do in a very near future. I've tested your PR with my applications, and everything works fine. :) @abersnaze @akarnokd : Please can you merge this PR soon and make a new release of RXJavaString? That would be very helpfull. Thanks by advance. 👍 |
|
👍 |
|
@notflorian thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes #33