Skip to content

Conversation

@JohnWowUs
Copy link

PR for issue #3577

@akarnokd
Copy link
Member

👍

@akarnokd akarnokd changed the title Added MergeDelay operators for Iterable of Observables 1.x: Added MergeDelay operators for Iterable of Observables Jan 22, 2016
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove final

@artem-zinnatullin
Copy link
Contributor

Just few things about code style, otherwise LGTM 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: MergeIterable -> mergeIterable

@zsxwing
Copy link
Member

zsxwing commented Feb 3, 2016

👍 once you fix the style issue

@stevegury
Copy link
Member

👍 after renaming the mergeIterable method.

@zsxwing
Copy link
Member

zsxwing commented Feb 4, 2016

👍 @JohnWowUs can you please squash commits in your PR into one?

@zsxwing
Copy link
Member

zsxwing commented Feb 8, 2016

@JohnWowUs could you squash commits? Thanks!

@JohnWowUs
Copy link
Author

@zsxwing

Done.

@zsxwing
Copy link
Member

zsxwing commented Feb 8, 2016

👍

akarnokd added a commit that referenced this pull request Feb 8, 2016
1.x: Added MergeDelay operators for Iterable of Observables
@akarnokd akarnokd merged commit 6052a02 into ReactiveX:1.x Feb 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants