-
Notifications
You must be signed in to change notification settings - Fork 7.6k
1.x: Added MergeDelay operators for Iterable of Observables #3627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👍 |
src/main/java/rx/Observable.java
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove final
|
Just few things about code style, otherwise LGTM 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: MergeIterable -> mergeIterable
|
👍 once you fix the style issue |
|
👍 after renaming the |
|
👍 @JohnWowUs can you please squash commits in your PR into one? |
|
@JohnWowUs could you squash commits? Thanks! |
a5c70ca to
d179699
Compare
|
Done. |
|
👍 |
1.x: Added MergeDelay operators for Iterable of Observables
PR for issue #3577